Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoinjector resprite (Adoption of #7100) #15970

Merged
merged 4 commits into from Oct 6, 2023

Conversation

DisturbHerb
Copy link
Contributor

@DisturbHerb DisturbHerb commented Sep 23, 2023

[MEDICAL][OBJECTS]

About the PR

This is an adoption of #7100 by @BatElite with minor code changes. The description below has been copied verbatim from the original PR.

Fancy sprites for autoinjectors (based on real life ish designs), with ever fancier animations on using them

  • VR flavours
  • Big flavours (+ figure out what to do with animations for them)
  • The state I left the icon updating code in is uhhhh
    • Superseded by this PR.

This is just a brief draft for now I'm gonna leave this for now and bap the morgue PR

image

Why's this needed?

New sprites good, perhaps.

Changelog

(u)BatElite
(+)Auto-injectors have been resprited!

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Medical Deals with our medical system in some way labels Sep 23, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 23, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2023
@NightmareChamillian
Copy link
Contributor

I love the art, I think the sprites are great, but I'm concerned about the practical implications of merging this:

spent autoinjectors, especially later in a round, tend to litter medbay's floor. Having larger autoinjector sprites, as well as ones that don't quite as obviously differentiate between spent and unspent seems like it'll detract slightly from QoL.

@DisturbHerb
Copy link
Contributor Author

spent autoinjectors, especially later in a round, tend to litter medbay's floor. Having larger autoinjector sprites, as well as ones that don't quite as obviously differentiate between spent and unspent seems like it'll detract slightly from QoL.

maybe doctors should try using the bin /j

the photo is rather old given that the PR is itself rather old and was iterated on before it closed, they're easier to differentiate now at the very least

@Glamurio
Copy link
Contributor

I love the art, I think the sprites are great, but I'm concerned about the practical implications of merging this:

spent autoinjectors, especially later in a round, tend to litter medbay's floor. Having larger autoinjector sprites, as well as ones that don't quite as obviously differentiate between spent and unspent seems like it'll detract slightly from QoL.

I don't necessarily think that people littering the floor should be a reason not to have nice, easy readable sprites. If anything, dirty ground is a great reason to create gameplay to clean up or call a janitor. Some medbays even have a vacuum cleaner, just use that.

@MeggalBozale
Copy link
Contributor

I don't think it would do much to make the sprites 'more obvious' except encourage people to clean up after each other using autoinjectors. And I certainly don't see it as a reason to not have cooler sprites. Also, it's not like there was much opportunity to tell between spent/unspent as-is.

@flappybatpal
Copy link
Contributor

They are already litter, if anything having them larger might encourage more tidying up.

@ZeWaka ZeWaka added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Oct 5, 2023
@flappybatpal flappybatpal added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Oct 5, 2023
@flappybatpal flappybatpal merged commit 0aae259 into goonstation:master Oct 6, 2023
28 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
@flappybatpal flappybatpal removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Oct 6, 2023
@DisturbHerb DisturbHerb deleted the abto-injebctor branch October 6, 2023 08:46
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Medical Deals with our medical system in some way C-Sprites Automatically applied on any .dmi or icons folder change E-Add-To-Wiki A PR that will require changes to the wiki S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants