Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasp related items in surplus crates come with a wasp implant #15982

Merged
merged 4 commits into from Sep 25, 2023

Conversation

unfunnyperson
Copy link
Contributor

@unfunnyperson unfunnyperson commented Sep 23, 2023

About the PR

If wasp grenades are rolled in a surplus crate they come with a wasp implant. Wasp implants give the user the botany faction which prevents wasps from attacking them. Wasp implants also cause the user to explode into 8 wasps on death.
Additionally enables the wasp crossbow in surplus crates and adds a wasp implant when that is rolled.

Why's this needed?

Wasp grenades are significantly less useful when rolled in a surplus crate because the user lacks botany's wasp immunity. The implant allows this item to be used to its full potential.
I added the crossbow to crates cause I noticed a comment about it being disabled due to issues with wasps killing their summoners but that shouldn't an issue because of the implant.

The user exploding into wasps on death is meant to be a fun little bonus when you get one of these items in a surplus.

Changelog

(u)UnfunnyPerson
(+)Added the wasp crossbow to surplus crates.
(+)Wasp related items in surplus crates come with a wasp implant. The wasp implant will cause wasps to ignore the user and for the user to explode into wasps on death.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2023
@unfunnyperson unfunnyperson added C-Feature A new feature or enhancements to existing features A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities E-Add-To-Wiki A PR that will require changes to the wiki labels Sep 23, 2023
@MeggalBozale
Copy link
Contributor

Personally I think the amount of wasps you burst into on death should be a bit more, especially since you gib for it. 8 pops into my head, but just IMO

Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faction implant idea is cool, not too sure on having it also be a revenge implant - probably fine though

code/obj/item/implant.dm Outdated Show resolved Hide resolved
@Tarmunora Tarmunora merged commit 28c2c97 into goonstation:master Sep 25, 2023
27 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@unfunnyperson unfunnyperson deleted the wasp-implant branch September 25, 2023 22:22
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Feature A new feature or enhancements to existing features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants