Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressure sensor streamlining #16040

Merged
merged 7 commits into from Sep 28, 2023
Merged

Pressure sensor streamlining #16040

merged 7 commits into from Sep 28, 2023

Conversation

kbsmilk
Copy link
Contributor

@kbsmilk kbsmilk commented Sep 26, 2023 •
edited

[GAME OBJECTS] [QOL]

About the PR

  • Makes the pressure sensor easier to use in general. Mousedrop support + crystal extraction with bare hand (or crowbar like it was before)
  • pressure crystal survives the sensor getting exploded.
  • visible messages instead of just boutput.
  • +examine text. +code quality. +overlay bug fixed.

Why's this needed?

Less clunk. Something of a companion PR to #15933

Changelog 

(u)Smilg
(+)Pressure sensor can now use empty hand, and mouse drop.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2023
@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play labels Sep 26, 2023
TobleroneSwordfish
TobleroneSwordfish requested changes Sep 27, 2023
View reviewed changes
code/obj/item/device/transfer_valve.dm Show resolved Hide resolved
code/obj/item/device/transfer_valve.dm
. = ..()
if (!istype(thing, /obj/item/pressure_crystal))
return
if (src.insert_crystal(user, thing))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This displays "You contemplate how to place the crystal in an occupied sensor, but can't manage to figure out how." when putting a crystal into an empty sensor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce this with mouse drop. It should be fully handled in insert_crystal()

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 27, 2023
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 28, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit 15bb53b into goonstation:master Sep 28, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@robuddybot
Changelog for #16040 [skip ci]
e859c16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobleroneSwordfish TobleroneSwordfish TobleroneSwordfish requested changes

Assignees
No one assigned
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbsmilk @TobleroneSwordfish