Crew Credits Antagonists Tab #16185
Crew Credits Antagonists Tab #16185
Conversation
Mister-Moriarty
requested review from
mordent-goonstation,
ZeWaka and
Sovexe
as code owners
keywordlabeler
bot
added
A-UI
github-actions
bot
added
size/XXL
|
Hell yeah! Looks great. |
Mister-Moriarty
force-pushed
the
antagonist-credits
branch
from
43c32da
to
e8cfb63
Compare
github-actions
bot
removed
the
S-Merge-Conflict
| <Flex | ||
| inline | ||
| align="center" | ||
| key={index}> | ||
| {!!item.icon && ( | ||
| <Flex.Item> | ||
| <Image | ||
| height="32px" | ||
| width="32px" | ||
| pixelated | ||
| src={`data:image/png;base64,${item.icon}`} | ||
| /> | ||
| </Flex.Item> | ||
| )} | ||
| <Flex.Item | ||
| pr={1} | ||
| pl={0.5}> | ||
| {item.name} | ||
| {`${index === arr.length - 1 ? '' : `, ${index === arr.length - 2 ? 'and ' : ''}`}`} | ||
| </Flex.Item> | ||
| </Flex> |
There was a problem hiding this comment.
Rather than setting pr, pl etc., does this work if you use a Stack instead of Flex? Unsure how that spacing would look here.
There was a problem hiding this comment.
I'm using Flex so to avoid spacing other than where explicitly stated.
|
|
||
| import { Flex, Image } from '..'; | ||
|
|
||
| export const ItemList = (props: ItemListProps) => { |
There was a problem hiding this comment.
Broadly can't see much use for this yet outside of CrewCredits. Probably put in there rather than in the common spot, and if someone wants it they can pull it out and change the import, it's just one line.
There was a problem hiding this comment.
I would rather have ItemList be located in the common components list; in order to pull it out of the crew credits folder, and individual first has to know it is located there, whereas when in the common list, it is more visible to UI coders, and as a result is more likely to be used.
|
Thank you kindly for the UI review. |
github-actions
bot
added
the
S-Merge-Conflict
| @@ -26,6 +26,8 @@ datum/mind | |||
|
|
|||
| /// A list of every antagonist datum that we have. | |||
| var/list/datum/antagonist/antagonists = list() | |||
| /// A list of every antagonist datum subordinate to this mind. | |||
| var/list/datum/antagonist/subordinate/subordinate_antagonists = list() | |||
There was a problem hiding this comment.
Shouldn't this be stored on the antag datum, or are subordinate antags technically linked to the mind instead?
There was a problem hiding this comment.
Subordinate antagonists track their master's mind directly.
github-actions
bot
removed
the
S-Merge-Conflict
TobleroneSwordfish
added
the
S-Testmerged
[UI] [QoL]
About The PR:
Implements an antagonists tab to the end of round crew credits, displaying details regarding each major antagonist of the round, including their antagonist roles; job; status; objectives; general statistics, such as purchased equipment or blood drank; and their subordinate antagonists.
Antagonists not considered major, such as subordinate antagonists, generic antagonists, or revolutionaries will be displayed under the "Other Antagonists" section. If a subordinate antagonist has a master, they will instead be listed under their master's data entry.
Additionally to better facilitate a tab oriented structure, the crew credits datum has been refactored.
Why Is This Needed?
Deprecates the old text window readout of antagonist statistics, and therefore fixes #15870.
Changelog: