Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sci-class Requisition: "Prototypist" #16191

Merged
merged 16 commits into from Oct 8, 2023

Conversation

Kubius
Copy link
Contributor

@Kubius Kubius commented Oct 2, 2023

[FEAT]

About the PR

This PR adds a single new complex requisition in the Scientific class, referred to as the "Prototypist" contract, and several items to serve as unique rewards for some of its outcomes.

Core Details

Prototypist contract generation is highly variable. Each contract can pick from a range of possible prototypist clients (currently three, but this can expand in future with new ideas), and select from one of three possible goals that this client has: prototyping a new product, refining an existing one, or improving manufacturing.

Each combination of client and goal has a unique reward, and sometimes requisitioned items relating to the reward; there are also common requisitioned items among all possible rewards for a client.

Some of these rewards have been created specifically for the requisition.

Clients and Rewards

Safety Equipment Manufacturer

  • Prototyping: An ExoWeave space suit set (newly added for requisition). Using a custom-tooled fabric with several material reinforcements, it offers improved protection and reduced bulk compared to conventional space suits.
  • Refinement: An SUV suit with an industrial space helmet.
  • Manufacture: Four to six pieces/sets of conventional protective suits. Possible outcomes are paramedic suits, heavy firesuits, light space suit sets, emergency space suit sets (count doubled), or radiation suit sets.

Directed Energy Laboratory

  • Prototyping: The Hedron beam device (newly added for requisition). This serves as a hybridized laser drill and welding tool, able to switch between these functionalities on the fly; it comes with a 100-unit power cell, and consumes 5 units of power for every 1 fuel a conventional welder would expend (giving it similar effective weld capacity before requiring a refuel), or 2 for each mining operation.
  • Refinement: An upgraded cargo transporter (newly added for requisition). It offers a 20% efficiency improvement over a conventional cargo transporter (uses 20 cell units instead of 25 per transport) and transports objects 33% faster (2 second action bar instead of 3).
  • Manufacture: Surplus directed-energy equipment. This individually picks two to three of the following items: pod plasma cutter system, pod Mk.2 scout laser, pod Mk.1 combat taser, RP-3 micro phaser, taser gun, energy gun junior, large laser emitter (singulo one), Epsilon interdictor rod, Sigma interdictor rod.

Engineering Firm

  • Prototyping: Biomimetic rapid construction device (newly added for requisition). It's a material RCD that builds with viscerite (including the ability to form a "tensed" viscerite for windows that's translucent) and can consume regular and tensed viscerite for construction matter; in exchange for this capability, it can't construct airlocks. It's also a safe-deconstruct variant.
  • Refinement: Three to five high-capacity welding tools.
  • Manufacture: Engineering equipment off the firm's production line. You receive 4 to 6 units of one of the following: cable coils, RCD cartridges, 10-sheet stacks of mauxite, charged 15k power cells, utility belts, RTG pellets (with an RTG frame).

One small supplementary change is mech-scannability for the material analyzer, as it's an item I picked out for requisition input and it wasn't mech-scannable for some reason.

Why's this needed?

Adds to the relatively limited Scientific requisition lineup in a way that significantly spices up reward structure.

Changelog

(u)Kubius
(+)A new type of Scientific requisition is available. Its cash reward is lower, but it offers an item reward in return - and sometimes, it's one you can't get elsewhere.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Oct 2, 2023
@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Oct 2, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2023
@flappybatpal
Copy link
Contributor

We have a lot of issues with "light" spacesuits being the power gamer choice, how available/easy to get would the SpaceLite set be?

@Kubius
Copy link
Contributor Author

Kubius commented Oct 2, 2023

It's a one-in-nine chance for one set be available if the contract shows up, and requires fulfillment of two pieces of high-grade cloth (carbon fiber or bee wool) and 20 units of silicate, in addition to the generic requirements (70% chance of 1-3 fibrilith, 70% chance of 1-3 cotton, 30% chance of 1 pharosium, 70% chance of 1 material analyzer).

Access to the opportunity will be semi-frequent, but between the high-grade cloth and fibrilith requirements, it's unlikely to actually be acquired at a reliable early time in the round. I've also tuned it to be slightly slower than an outright light-weight space suit (0.1 space movespeed instead of 0 on the body).

(As a side note, the SUV suit also requires two pieces of high-grade cloth to be exchanged, as well as one piece of uqill instead of the silicate.)

Copy link
Member

@frawhst frawhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misc thoughts:

  • Overall system is cool
  • Sprite for the efficient cargo tele looks a bit too similar to the regular one, maybe make it orange or something (and then rename the icon_state ofc).

code/modules/economy/requisition/rc_scientific.dm Outdated Show resolved Hide resolved
code/modules/economy/requisition/rc_scientific.dm Outdated Show resolved Hide resolved
code/modules/economy/requisition/rc_scientific.dm Outdated Show resolved Hide resolved
code/modules/economy/requisition/rc_scientific.dm Outdated Show resolved Hide resolved
code/modules/economy/requisition/rc_scientific.dm Outdated Show resolved Hide resolved
code/obj/item/tool/hedron_beam.dm Outdated Show resolved Hide resolved
code/obj/item/tool/hedron_beam.dm Outdated Show resolved Hide resolved
code/obj/item/tool/hedron_beam.dm Outdated Show resolved Hide resolved
code/obj/mining.dm Show resolved Hide resolved
code/obj/item/tool/hedron_beam.dm Outdated Show resolved Hide resolved
@Kubius
Copy link
Contributor Author

Kubius commented Oct 2, 2023

Sprite for the upgraded cargo transporter is deliberately similar to the regular one since the impression is that it's using the same underlying technology with some fine adjustments (like a different casing material for less interference and the little prongs for focus) to eke out extra efficiency. I have a couple ideas for further distinguishing features if desired, but I wanted to keep it feeling like a variant of the same device.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2023
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 2, 2023
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 3, 2023
@frawhst frawhst merged commit 1fe5fad into goonstation:master Oct 8, 2023
22 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants