Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate Manufacturer Rebalance #16264

Merged
merged 3 commits into from Oct 20, 2023

Conversation

CrystalClover
Copy link
Contributor

@CrystalClover CrystalClover commented Oct 4, 2023

[BALANCE] [QoL] [GAME OBJECTS]

About the PR

Crate Manufacturer starting materials changed from 5 steel to 2 steel and 2 wood
Crates now only require 0.1 material to make, doubling the amount of crates able to be made
Wooden and Packing (cardboard) Crates now require wood material instead of steel

Why's this needed?

Crates needn't require so much material to make, especially when they are deconstructed into only 1 sheet.
Transmuting steel into wood/cardboard doesn't make sense
Wood is now easily obtainable to QMs via ordering, so it can be refilled easily

(u)CrystalClover
(+)Crates of all sorts are now cheaper to fabricate

2 metal & 2 wood, crates now only take
0.1 material, cardboard and wooden crates
now require wood
@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-QoL A quality of life improvement that makes the game easier to play labels Oct 4, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2023
@mordent-goonstation
Copy link
Contributor

Doesn't this quadruple the amount that can be made, given that you can make 20 steel types and 20 wood types? Drop to 1 steel/1 wood at round start and I think it'll be fine. That's 10 steel-type and 10 wood-type ones, and as you say very cheap to refill.

@BatElite
Copy link
Contributor

BatElite commented Oct 5, 2023

I don't really see the point of the cost change. crate production being a loss of materials is fine and frankly sensible, it's not like either part of the equation is in short supply.

Also we have cardboard material, why not use that in the packing crates directly rather than substitute one poor fit for another?

@CrystalClover
Copy link
Contributor Author

I don't really see the point of the cost change. crate production being a loss of materials is fine and frankly sensible, it's not like either part of the equation is in short supply.

Also we have cardboard material, why not use that in the packing crates directly rather than substitute one poor fit for another?

Packing crates use wood since its easier to refill, cardboard is a difficult material to obtain

@CrystalClover
Copy link
Contributor Author

Doesn't this quadruple the amount that can be made, given that you can make 20 steel types and 20 wood types? Drop to 1 steel/1 wood at round start and I think it'll be fine. That's 10 steel-type and 10 wood-type ones, and as you say very cheap to refill.

This makes sense, i will reduce it to 1

Copy link
Contributor

@MeggalBozale MeggalBozale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, it's just number and recipe tweaks after all.

I'm all for this change. QM can buy 20 metal bars whenever they want (Or 5 wood) and I don't see why crates, which turn into 1 sheet when wrenched, should cost more than exactly this to make (1 sheet).

Copy link
Contributor

@mordent-goonstation mordent-goonstation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a minor changelog entry, else LGTM

@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Oct 20, 2023
@ZeWaka ZeWaka merged commit 5cae344 into goonstation:master Oct 20, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-QoL A quality of life improvement that makes the game easier to play S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants