New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cream & Yoghurt additions/reworks #16288
Cream & Yoghurt additions/reworks #16288
Conversation
every 10 units, spits out remaining milk and container
…tation into Cream-Rework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, though a bit broad! I've made suggestions, mostly about keeping some empty space in the food proportional to it's reagent volume - this helps people make more customized food as well as allowing poisonings to occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me!
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine code-wise. In the future I'd suggest atomizing some more. The cream obj and its addition to existing foods, changing a bunch of cookie reagents, and making condiments unusable on other condiments: all three of these could be separated by scope, into 3 different PRs.
I forgot to mention, the changelog is way too big IMO. At most, I'd suggest 1 major and 1 minor, or just 2 minor, explaining cream and yoghurt's additions and a brief line about their recipe. |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
eb1490c
into
goonstation:master
[CATERING] [CHEMISTRY] [REWORK] [QoL]
About the PR
Additions:
Cream reagent: Taken from cream (condiment), breaks down into milk and cholesterol
Yoghurt reagent: Made from combining Milk and ????, heals damage to the intestine
Reworks:
Food Processor:
Now converts every 10 units of milk or yoghurt in a drinks container into cream and yoghurt (food) respectively, and dispenses the remaining container with any milk/yoghurt that wasn't used.
Frozen Yoghurt & Yoghurt:
Both contain 10 units of Yoghurt, and give you a Disease Resist buff, Frozen Yoghurt also gives you the Cold Food buff
Condiments:
You cannot apply a condiment to a food if the condiment contains no reagents
(does not affect things such as adding maple syrup to pancakes)
You cannot add a condiment to another condiment
Cream of Mushroom:
Now requires Cream instead of Milk, is cooked for 8 seconds on low in an oven (or 4 seconds on high)
The following foods have had their reagents changed:
Icecream - Starts with 10 units of Cream
Cream Pie - Starts with 10 units of Cream
Cream of Mushroom - Starts with 10 units of Cream
Creamy Sponge Cake - Starts with 20 units of Sugar & 10 units of Cream
All Cookies - Now contain chems that come from the constituant parts
All Moon Pies - Inherit the chems from the cookies used and also start with 10 units of Cream
Rancid Milk - Now contains 25 units of yoghurt and 25 units of ????
Why's this needed?
Makes cream and yoghurt much easier to obtain and gives them more uses, the items with changed reagents now make more sense than having none at all
Changelog