New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tgui teleconsole #16319
tgui teleconsole #16319
Conversation
This reverts commit feb75e7.
Why's the window so big compared to its content? |
I have made the window slightly smaller by default. Images updated to reflect this |
hmm.. not really an issue exactly, but with the current telescience console UI, cyborgs are able to interact with it from anywhere. making it TGUI would make it only interactable to cyborgs within viewing range. Which, while it seems to be the intention with computer interfaces as a general rule, should be at least noted down, considering how valuable a tool telescience can be in the silicon arsenal. |
I feel like this should be part of sciborgs kit/an upgrade. In the meantime you can always ask the AI |
Standardizing this is worthy of a note, but I would think is worth doing as it reduces surprises. The AI (and I believe AI controlled cyborgs, though would have to double check that) still have access to it from anywhere. |
An upgrade that increases the interaction range from ~1 screen to more (or even the whole z-level, a la AI) sounds neat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some additional design feedback but that can wait for a follow-up PR from myself or someone else, the port as the main chunk of the work seems mostly decent.
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly approving (with changes below), I think there's room for some design enhancements here but the base goal of "get it into tgui" seems to be fine, and I don't want to block that with my (subjective) design thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a "request changes" block on this until I've got some improvements added to the branch. Working on those actively, please hassle me if this takes >24 hours.
PRed my changes to your branch, so they can be merged in in one go rather than incrementally. |
About the PR
Replaces teleconsole's old ui with a tgui one
As a consequence, cyborgs can no longer interact with it from off-screen
Why's this needed?
tgui good
Changelog