QoL Changes to Sword Sheaths + Katana Sakuride Coating

[KevinfromHP]

About the PR

• All sword sheaths can now be interacted with in a more comfortable manner. You can now mouse drag to remove the sheath like any other bag.
• New feature: all katanas can now be coated with sakuride! Clicking on a pure beaker of sakuride will coat the katana in up to 15u of it. When you use your dash, it will now leave a trail of sakura petals behind you. Each tile uses one unit, so you have 5 dashes before it's used up. As of now, you can only coat it in sakuride, and it has no effect beyond this.

Why's this needed?

• The katana can be a pain in the ass to work with. The control changes felt like a necessity since you would have to take the sword out, then use you other hand to remove the sheath.
• The sakuride coating feels like a nice touch to the katanas. I just thought it'd be fun.

Changelog

(u) Kevin From HP
(+) Sword sheaths can now be dragged out of belt slot onto hand/ground.
(+) Using any katana on a container of pure sakuride will coat it in up to 15u. Dashing leaves a trail of petals behind you.

[DisturbHerb]

Don't think the workshop katana needs a sheath, myself.

[CheffieGithub]

Its incredibly weak for the time investment so a sheath is a nice small buff. Maybe some distintion from the normal katana sheath is a good idea though.

[CheffieGithub]

Personally intent based interactions feel bad but we don't really have a framework for other shortcuts as alternatives

[KevinfromHP]

I can drop the grab intent thing if that's what's preferred, I personally like how the shinai bag's intent changes things but if that's not a popular thing then that's alright. As for the sheath, if you're looking to use it for anything other than aesthetic then I feel like you'd be wasting your time. A strangelet loaf or even a loaf a few tiers lower is a greater return on time investment than that katana, if someone's gonna spend so much time on it I feel like they might as well get a place to put it.

[CheffieGithub]

Grab is fine but maybe being able to drag click it into your hands would be good as well

[KevinfromHP]

Grab is fine but maybe being able to drag click it into your hands would be good as well

Already done, same as a backpack/belt

[TobleroneSwordfish]

• Click dragging is good, but intent based inventory interactions are very unclear.
• The workshop katana not having a sheath is very intentional.
• The sakura petals are cute and cool 👍

[zjdtmkhzt]

What's the intent with the workshop not having a sheath? I feel like it would be much cooler if it did, katana without a sheath kind of just sucks from a coolness standpoint.

I agree though that it should probably have a different name and icon to make it so you do not appear to be an antagonist?

[KevinfromHP]

I considered a new sheath, but already being able to make both a handcrafted and reverse blade (which already has a sheath) there made me think it was best to go with a vanilla sheath.

I can drop grab intents easy enough, but if it were to receive its own unique sheath, could that change be kept?

[DisturbHerb]

I think being able to wear and draw a katana at will is something best left to the traitor katana. That's what I assumed the reasoning to be against providing sheaths for the workshop ones.

[KevinfromHP]

Though I disagree due to the lack of power of the katana(s) compared to other options, I'll drop the sheath.
However, I will leave my final thoughts on it. Reading over the discussion in the discord over this, I do not think the sheath would make a significant change to the way people play given the time it would take to create, a traitor's instant access to a better katana with a sheath, and the nature of "power gaming".
It surprised me how controversial this is considering many of the other options that are available, like the (storable) predator revolver and rifle on ice moon, a scrap plasma dagger, and the 120 seconds or less to obtain phaser in debris field. If someone were interested in a viable weapon, the 20-30 minute katana from the workshop seems illogical unless it was solely an aesthetic choice. I wouldn't see this as a major change to the game though people might see a katana slightly more often if it had a sheath.

[KevinfromHP]

• Click dragging is good, but intent based inventory interactions are very unclear.
• The workshop katana not having a sheath is very intentional.

These two things have been revised as requested

[Azrun]

I think this PR is doing far too many things. Sakura should be atomized to a separate PR.

[KevinfromHP]

I think this PR is doing far too many things. Sakura should be atomized to a separate PR.

If you removed sakuride coating from this PR, wouldn't it just be making the sword sheath mouse draggable?

The only other thing it has is the ability to spawn sheaths in map data but that's just an artifact from an old change to add a sheath to hidden workshop, I can drop that once I finish these changes

[TobleroneSwordfish]

This ideally should be atomized, yes, but I'm fine with merging it as the changes are relatively minor. Just in future please don't package different changes into one PR.

[KevinfromHP]

That commit says checks if human but it checks if it's a mob, my mistake