Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16459 Refactors genetics combine modal #16462

Conversation

mordent-goonstation
Copy link
Contributor

[BUG][UI]

About the PR

Fixes #16459 by refactoring modal to use a different way of displaying the list. Could probably use some more tidying up but gets the functionality back for now.

image

Why's this needed?

Cannot combine genes without it, as empty (former) checkboxes don't display.

Changelog

(u)Mordent
(+)Slight tweak to GeneTek UI for combining genes.

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Oct 15, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2023
@keywordlabeler keywordlabeler bot added the C-Bug A bug that impacts usage of a feature label Oct 15, 2023
@mordent-goonstation mordent-goonstation merged commit 308d468 into goonstation:master Oct 15, 2023
23 checks passed
@mordent-goonstation mordent-goonstation deleted the bugfix/combine-genes-modal branch October 15, 2023 05:00
github-actions bot pushed a commit that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Bug A bug that impacts usage of a feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot combine genes
1 participant