Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

donut2 camera reduction #16632

Merged
merged 3 commits into from Oct 28, 2023
Merged

donut2 camera reduction #16632

merged 3 commits into from Oct 28, 2023

Conversation

Sovexe
Copy link
Contributor

@Sovexe Sovexe commented Oct 25, 2023 •
edited

About the PR

  • Removes a bunch of cameras from donut2
  • Removes almost all maintenance cameras and adjusts the positions of some that peered into maintenance. The ones near the security dock and disposals are mostly untouched

heatmaps... blue -> red : 1 -> 5

Old: https://i.imgur.com/TUa0JEg.jpg
image
New: https://i.imgur.com/dgnLhhB.jpg
image

Why's this needed?

  • Reduce over coverage, some turfs were viewed by as many as 9 cameras. This makes camera cutting more viable, and reduces the overhead of camera setup
  • Reduce/eliminate maintenance coverage for most areas
(u)Sovexe
(*)Removed and repositioned many Donut2 security cameras to reduce redundant coverage and maintenance coverage.

@Sovexe Sovexe requested a review from Sord213 as a code owner October 25, 2023 01:34
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Oct 25, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 25, 2023
@Sovexe Sovexe added the C-Balance Balance changes, buffs and nerfs label Oct 25, 2023
@Sovexe Sovexe merged commit 525d6e1 into goonstation:master Oct 28, 2023
23 checks passed
@Sovexe Sovexe deleted the donut2-camera-reduction branch October 28, 2023 22:58
github-actions bot pushed a commit that referenced this pull request Oct 28, 2023
@robuddybot
Changelog for #16632 [skip ci]
bbef2de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sord213 Sord213 Awaiting requested review from Sord213 Sord213 is a code owner

Assignees
No one assigned
Labels
A-Mapping A mapping change C-Balance Balance changes, buffs and nerfs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sovexe