Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Sulfuric Acid Mixing Tweaks #16639

Merged

Conversation

Flaborized
Copy link
Contributor

About the PR

This PR changes some stuff about the chem rework sulfuric acid based on feedback I've gotten from it and some ideaposting in discord. In general they're orientated around making it less annoying to make while keeping it still a unique and weirdfun recipe.

  • Lowers the heat generated by it from 10 (kelvin) per cycle to 4 in an open container and 8 in a closed container. 10 was definitely too much, and even using something like cryostylane couldn't outpace the heat it was generating. It's meant to be something you can offset, so lower works better here.
  • Allows you to use steam in place of water, at the cost of using twice the units to make the same amount. This idea was suggested by rubberrats on discord and I liked it, since it's annoying to end up with like, 13u of sulfur and oxygen, 70u of acid at the end of everything. Using steam also decreases the efficiency of sulfur and oxygen in the recipe to match so you always end up with just acid at the end if the steam doesn't boil off. It also is still 'bad' but not as 'bad' as it was, so you're still incentivized to cool the reaction for max output per seconds spent mixing.
  • Changed the off-gassing threshold to be 50C instead of 20C, or 323.15K. This means an open container of sulfuric acid won't off-gas until it hits 323.15K. It was originally the intent for players to cool the reaction down first to get this, and be able to safely mix in an open beaker, but I think the interesting part of that is maintaining the temp and not initially cooling it, so raising the threshold beyond what it starts with is easier to work with.
  • Changed shatter behavior to instead break at 150C, or 423.15K, but still only in a closed beaker (though you won't mix it in an open beaker at this temp anyways because the steam will boil off and delete itself). The "breaking if it overfills" thing just doesn't really materialize much and is difficult to explain, the only way I've consistently seen it happen is by players just overfilling a beaker with reactants in a dispenser, and I think basing it off heat plays better with the theme of the chem and is easier to understand (and also to trigger by accident). It also means a closed barrel isn't a nearly 100% safe place to mix tons of very hot acid, too, which would be very strong with the steam changes I feel.
  • Also the heat generated in a closed beaker when its above 50C (from the 'vapor' that would be made in an open beaker that's retained) has its minimum floor lowered, again just making it overheat way less aggressively and quickly.

Why's this needed?

All the changes have their reasoning explained pretty clearly in the list, but generally speaking I wanted to tweak acid since it's a bit annoying with the update and something you have to make very frequently. This should also make it much easier to make precise amounts of acid, if you wanted to make a big complicated condenser setup, and make it less horribly punishing to mix it in an open beaker (since I want both open and closed beaker setups to be useful in some way) by making it generate substantially less heat and smoke, and letting you maintain that reaction with consistent cooling.

I also just wanted to address a bit of feedback I've gotten on chem changes I made, and try and make the process less tedious while keeping the interesting parts of the recipe that I like. I think for something so commonly made it could stand to be a bit more lenient at least.

Changelog

(u)Flaborized
(+)Some sulfuric acid tweaks: Steam can now be used in place of water, using twice as many reactants. Open sulfuric acid reactions now start offgassing at 323.15K. Closed container reactions now shatter if they hit 423.15K instead of when the container is full. Closed reactions now heat by 8K per cycle, and open ones heat by 4K, from 10K for both.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2023
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!


on_reaction(var/datum/reagents/holder)
if(holder.has_reagent("water"))
holder.remove_reagent("water", reaction_speed/2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably use created_volume rather than reaction_speed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true! pushed a fix

@TobleroneSwordfish TobleroneSwordfish merged commit e202ee1 into goonstation:master Oct 29, 2023
23 checks passed
@TobleroneSwordfish TobleroneSwordfish added the E-Add-To-Wiki A PR that will require changes to the wiki label Oct 29, 2023
github-actions bot pushed a commit that referenced this pull request Oct 29, 2023
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants