Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces amount of phenol needed for glue production #16653

Merged
merged 2 commits into from Oct 30, 2023

Conversation

colossusqw
Copy link
Contributor

@colossusqw colossusqw commented Oct 26, 2023

About the PR

This PR changes glue's recipe to 1 plasma, 1 oxygen, 1 hydrogen, 1 formaldehyde, 0.25 phenol, reduces total yield from 5 to 4.

Why's this needed?

After the chem update, many chems have currently become very resource intensive to produce, this PR focuses on reducing the work and time investment in the production of space glue via reducing the needed amount of formaldehyde and phenol.

(u)Colossusqw
(+)Glue's recipe now only requires 0.25 units of phenol.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@TDHooligan
Copy link
Contributor

3.2x yield for phenol, same yield for diethylamine. given diethylamine is a lot easier to make it seems fine. might not be a big enough change but it's a step in the right direction

@Tarmunora Tarmunora requested review from TobleroneSwordfish and Flaborized and removed request for Tarmunora October 27, 2023 02:06
@TobleroneSwordfish
Copy link
Contributor

I think I'd rather remove one of the precursors to make it easier to make, the idea is that stuff should require less chemicals to make but those chemicals should be more involved to produce.

@TDHooligan
Copy link
Contributor

i think that's a bit difficult as this is based on phenol-formaldehyde glue...

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm oka this works too

code/modules/chemistry/Chemistry-Recipes.dm Outdated Show resolved Hide resolved
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
@colossusqw colossusqw changed the title reduces amount of formaldehyde and phenol needed for glue production reduces amount of phenol needed for glue production Oct 29, 2023
@pali6 pali6 merged commit fb82ed6 into goonstation:master Oct 30, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@colossusqw colossusqw deleted the glue-recipe-simplify branch October 30, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants