Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take extra death rolls when you're being beaten on #16744

Merged
merged 6 commits into from Nov 15, 2023

Conversation

TDHooligan
Copy link
Contributor

@TDHooligan TDHooligan commented Nov 2, 2023

About the PR

Players in death saves take an extra death roll when they take 5 or more BRUTE, the damage dealt provides a logarithmic penalty to their success rate.

  • This only rolls when you're taking damage and would already be rolling for death
  • The roll can only be triggered once every 0.4 seconds (to limit rolls from rapid-fire weapons)
  • It ignores synatropine
  • It probably needs adjusting, depending on the results of a test merge (if any)
  • The penalty is 5% at 5 damage, requiring 2x additional damage to raise another 5%
    (5 = 5%, 15 = 10%, 35 = 15%, 75 = 20%)

image

Why's this needed?

Death rolls in crit are balanced around a few things:

  • They occur every life tick (so need to be a low % to not just kill you instantly)
  • People should have time to be treated, given they aren't very unlucky
  • Brain damage and OXY are introduced in huge quantities to adjust survival odds after 30 seconds or so

This causes some weird behaviour:

  • If you lack a crazy weapon, beating people down in deep crit provides little to no benefit (1 punch = +0.05% death odds)
  • Repeatedly point-blanking people with powerful kinetics can waste a LOT of ammo (ie if life ticks are slow)
  • Smacking people with strong weapons, when they are most certainly are dead, can feel frustrating if they have good RNG
  • With synatropine, you can tank obscene damage well past the 'you lose' threshold, RNG permitting.

I do, however, know that we like a good comeback - I am open to lowering the odds.

Changelog

(u)TDHooligan
(*)Brute damage now causes people in deep critical to roll extra death saves.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@pali6 pali6 requested a review from Tarmunora November 2, 2023 02:33
@pgmzeta pgmzeta added C-Balance Balance changes, buffs and nerfs A-Medical Deals with our medical system in some way labels Nov 2, 2023
@M-Earthfire
Copy link
Contributor

M-Earthfire commented Nov 2, 2023

I kinda feel like this should have a minimum damage to trigger. Roling additional death rolls on someone in full armor when you try to hit them with punches kinda sound silly, even if the additional chance is really low.

But beyond that, i am kinda liking it, but got no idea if the numbers are right. That is something i would certainly like to see play out in a testmerge.

@TDHooligan
Copy link
Contributor Author

i forgot to write it only rolls on 5+ brute

@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Nov 7, 2023
@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Nov 8, 2023
@TDHooligan TDHooligan changed the title Add extra death saves for when you're being beaten on Take extra death rolls when you're being beaten on Nov 8, 2023
@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Nov 8, 2023
@TDHooligan
Copy link
Contributor Author

i don't see many negative comments about this - from my perspective the numbers could be good as-is.

@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Nov 15, 2023
@pali6 pali6 merged commit f963e8a into goonstation:master Nov 15, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@TDHooligan TDHooligan deleted the crunch_'em branch March 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Medical Deals with our medical system in some way C-Balance Balance changes, buffs and nerfs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants