Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Counter-Revolutionary Implants from QM to Security #16772

Closed
wants to merge 1 commit into from

Conversation

FlameArrow57
Copy link
Contributor

@FlameArrow57 FlameArrow57 commented Nov 4, 2023

[GAME MODES][GAME OBJECTS][BALANCE][INPUT WANTED][QoL]

About the PR

This PR removes counter-revolutionary implants as a QM purchase.

A counter-revolutionary implant dispenser is now found in the Security department on each map. Each can hold a max of 7 implants and will auto-fabricate implants every 12 seconds up to its max.

Also removes a single loyalty implant box from each map to account for the dispenser.

Maybe it goes against the theme of the station to buy new implants, not sure.

Why's this needed?

This is mainly meant to counter revs going for QM deconstruction. If QM computers are deconstructed, and the spare board in tech storage is destroyed, the only other way to get new implants is to mechscan SecTechs, but that's rarely done/thought of too.

This helps add a way of preventing revs from completely shutting down obtaining implants.

Also, probably a lot of ways you can think about how this would change things, but I would imagine it would also help reinforce Security as a place to be wary of, and that revs really need to group up on to attack. Maybe it will allow some more interesting fights when attacking Security?

Changelog

(u)FlameArrow57
(*)Counter-revolutionary implants are no longer a QM purchase. Instead, a new counter-revolutionary implant dispenser is found in each Security department, which holds up to 7 implants and auto-fabricates implants every 12 seconds.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs C-QoL A quality of life improvement that makes the game easier to play labels Nov 4, 2023
@boring-cyborg boring-cyborg bot added A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change labels Nov 4, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2023
@keywordlabeler keywordlabeler bot added the C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. label Nov 4, 2023
@DisturbHerb
Copy link
Contributor

There would be minimal counterplay against Security's ability to keep order. While QM destruction can be very cheesey as a tactic, I don't think this is the solution myself.

@Boredone
Copy link

Boredone commented Nov 4, 2023

If nothing else, only 12 seconds per implant is kinda absurdly fast? That's more then the crate every minute if folks empty it fast enough.

@FlameArrow57
Copy link
Contributor Author

If nothing else, only 12 seconds per implant is kinda absurdly fast? That's more then the crate every minute if folks empty it fast enough.

Maybe, dunno. Average of 5 per minute, each crate comes with 4 but sometimes they'll be bought in batches.

@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Nov 4, 2023
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Created discussion thread: https://forum.ss13.co/showthread.php?tid=21955

@CheffieGithub CheffieGithub added the S-Controversial This requires a heightened standard of review before it can be merged label Nov 4, 2023
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Nov 5, 2023
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 20, 2023
@FlameArrow57 FlameArrow57 marked this pull request as draft November 20, 2023 02:27
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Gamemodes Changes or additions to any gamemode's main features A-Mapping A mapping change C-Balance Balance changes, buffs and nerfs C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. C-QoL A quality of life improvement that makes the game easier to play C-Sprites Automatically applied on any .dmi or icons folder change E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Controversial This requires a heightened standard of review before it can be merged S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants