Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes printing press making blank books #16784

Merged
merged 4 commits into from Nov 5, 2023

Conversation

TealSeer
Copy link
Contributor

@TealSeer TealSeer commented Nov 4, 2023

[BUG] [GAME OBJECTS]

About the PR

Fixes #15775 by making the declare_contents proc not try to do clever pass by reference stuff because that doesn't work. Also fixes two other bugs I found while doing this wherein: The code to set custom newspaper contents was all there but the option was not in the list, and the input box for newspaper headline auto-filled with the currently set book name instead of the headline.

Why's this needed?

The people want to write

Changelog

(u) TealSeer
(+) The printing press actually prints books with words in them now!

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Bug A bug that impacts usage of a feature labels Nov 4, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2023
@pali6 pali6 merged commit e6246ac into goonstation:master Nov 5, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 5, 2023
@TealSeer TealSeer deleted the printing-press-fix branch November 5, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Bug A bug that impacts usage of a feature size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Printing Press Makes Blank Books
2 participants