New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span macros to replace alot of spans #16820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pali <6pali6@gmail.com>
CheffieGithub
requested review from
pali6,
Tarmunora,
Sovexe,
mordent-goonstation,
Kyle2143,
Gannets,
flrsh and
frawhst
as code owners
November 6, 2023 23:55
github-actions
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Nov 6, 2023
CheffieGithub
added
A-Internal
Deals with major internal, generally non-player facing code - e.g. types
C-Code-Quality
Cleans up code, refactors things to be more readable or intuitive
C-QoL
A quality of life improvement that makes the game easier to play
labels
Nov 6, 2023
github-actions
bot
added
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Nov 7, 2023
pali6
reviewed
Nov 7, 2023
@@ -0,0 +1,51 @@ | |||
/* ====== SPAN MACROS ====== */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is something preventing that I think these should use string interpolation instead of +.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Internal
Deals with major internal, generally non-player facing code - e.g. types
C-Code-Quality
Cleans up code, refactors things to be more readable or intuitive
C-QoL
A quality of life improvement that makes the game easier to play
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Replaces most
<span ='class'>msg</span>
withSPAN_CLASS(msg)
. There are limitations of this such as not being able to be used in descriptions unless the entire description is in the macro for example (since the macro evaulates to just a string).Some spans I intentionally left out due to only using local css for one file.
I used these regexes in this order:
Any errors were manually resolved (this includes 100+ missing / malformed tags and most instances of
text()
usage)Why's this needed?
Mistakes while writing spans such as missing or malformed end tags are very common.
It should make some areas of code easier to read and shorter depending what classes are used.
Its somewhat easier to maintain this way.
Changelog