Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some items not being addable to artifact bags of holding #16862

Merged
merged 2 commits into from Dec 11, 2023

Conversation

FlameArrow57
Copy link
Contributor

@FlameArrow57 FlameArrow57 commented Nov 10, 2023

[GAME OBJECTS][PLAYER ACTIONS][BUG]

About the PR

This PR fixes some items, like multitools, not being able to be added to artifact bags of holding.

Also, activator keys will now have the same effect when added to a bag of holding with an origin they can activate as adding another bag of holding.

Why's this needed?

Bug fix, fixes #16834

Changelog

(u)FlameArrow57
(+)It's no longer advised to put an activator key into a bag of holding it can activate!

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Bug A bug that impacts usage of a feature labels Nov 10, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2023
@FlameArrow57 FlameArrow57 removed the request for review from pali6 November 10, 2023 00:57
@keywordlabeler keywordlabeler bot added the A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities label Nov 10, 2023
code/obj/artifacts/artifactprocs.dm Outdated Show resolved Hide resolved
@FlameArrow57 FlameArrow57 marked this pull request as draft November 16, 2023 05:00
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2023
@FlameArrow57 FlameArrow57 marked this pull request as ready for review November 26, 2023 01:06
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 11, 2023
@Tarmunora Tarmunora merged commit 92a0945 into goonstation:master Dec 11, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Bug A bug that impacts usage of a feature S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact Bag of Holding and multitools
2 participants