New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PTL to Nadir #16899
Add PTL to Nadir #16899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable on the whole. I'd say probably skip connecting up the catalytic substations, as they're the map's equivalent to solars, but I don't have an explicit objection to laying a cable for engineers to hook them up with.
I'd agree that the cat stations shouldnt be connected to it. Aside from being inconsistent with how passive generators are normally wired, having them on separate grids is helpful because it means that one hotwired grid doesnt compromise multiple generators. Otherwise they sort of lose their utility as a backup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am excited to see all the hotwires and meltdowns.
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fantastic!
It's been stale for a while though, so I have to ask; is there a good reason why it hasn't been merged yet that I don't know about? Or was it just forgotten a little (totally understandable)
P.S. typical colour schema for the cable line leading off the reactor network is to use a blue cable to indicate "this bit goes to the ptl". Totally optional of course, but i'm partial to it personally. Maybe worth considering?
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
Will this be merged? |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
About the PR
Adds a PTL to Nadir, replacing the SE random-spawn room. It is connected to the turbine and southern catalytic engines.
The high-voltage was stylistically laid with large radius bends. The turbine-wire travels through the false walls of SE maint as a shortcut. Notably false-walls must be deconstructed in order to manipulate wires underneath.
Side-effect: The southern catalytic engine grid is connected to the turbine grid; either engine can charge the other's intended SMES units; muddies the clarity of the
power monitor
computer'sEngine Output
graph (it is a sum of all engines). The connection can be easily undone (revert a commit).I also intentionally engine-electrified this wingrille.
Changes have been tested:
The windows have become properly transparent since taking the screenshot below.
I used the stronger windows (like those found near Escape) as it's an "important" station area.
Why's this needed?
馃挷馃馃捀馃挵馃挼馃挻馃挾馃挿馃挶馃捁馃挸
Incentivizes aggressive nuclear-engine & catalytic-engine use. Side effects may include:
Changelog