Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PTL to Nadir #16899

Merged
merged 2 commits into from Jan 30, 2024
Merged

Add PTL to Nadir #16899

merged 2 commits into from Jan 30, 2024

Conversation

MarkNais
Copy link
Contributor

About the PR

Adds a PTL to Nadir, replacing the SE random-spawn room. It is connected to the turbine and southern catalytic engines.
The high-voltage was stylistically laid with large radius bends. The turbine-wire travels through the false walls of SE maint as a shortcut. Notably false-walls must be deconstructed in order to manipulate wires underneath.

Side-effect: The southern catalytic engine grid is connected to the turbine grid; either engine can charge the other's intended SMES units; muddies the clarity of the power monitor computer's Engine Output graph (it is a sum of all engines). The connection can be easily undone (revert a commit).

I also intentionally engine-electrified this wingrille.
image

Changes have been tested:

  • Connections confirmed to both engine types,
  • PTL profit generated, and
  • All APCs charging.

The windows have become properly transparent since taking the screenshot below.
I used the stronger windows (like those found near Escape) as it's an "important" station area.
image

Why's this needed?

馃挷馃馃捀馃挵馃挼馃挻馃挾馃挿馃挶馃捁馃挸
Incentivizes aggressive nuclear-engine & catalytic-engine use. Side effects may include:

  • Increased cooperation with Siphon personnel.
  • Increased usage of the catalytic engines.
  • Increased traitor activity w/ reactor.
  • Increased traitor activity w/ hot-wiring.
  • An decrease in "Days since last meltdown". image

Changelog

(u)MarkNstein
(*)Nadir: Added a PTL located at the South East hull connected to the turbine and southern catalytic engines.

@MarkNais MarkNais added C-Feature A new feature or enhancements to existing features A-Mapping A mapping change E-Add-To-Wiki A PR that will require changes to the wiki labels Nov 12, 2023
@MarkNais MarkNais requested a review from Kubius November 12, 2023 22:49
@MarkNais MarkNais self-assigned this Nov 12, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 12, 2023
Copy link
Contributor

@Kubius Kubius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable on the whole. I'd say probably skip connecting up the catalytic substations, as they're the map's equivalent to solars, but I don't have an explicit objection to laying a cable for engineers to hook them up with.

@Cherman0
Copy link
Contributor

I'd agree that the cat stations shouldnt be connected to it. Aside from being inconsistent with how passive generators are normally wired, having them on separate grids is helpful because it means that one hotwired grid doesnt compromise multiple generators. Otherwise they sort of lose their utility as a backup.

Copy link
Contributor

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am excited to see all the hotwires and meltdowns.

@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Nov 30, 2023
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 15, 2023
Copy link
Contributor

@TheTyrant25 TheTyrant25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fantastic!

It's been stale for a while though, so I have to ask; is there a good reason why it hasn't been merged yet that I don't know about? Or was it just forgotten a little (totally understandable)

P.S. typical colour schema for the cable line leading off the reactor network is to use a blue cable to indicate "this bit goes to the ptl". Totally optional of course, but i'm partial to it personally. Maybe worth considering?

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 20, 2023
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 3, 2024
@github-actions github-actions bot closed this Jan 10, 2024
@TheTyrant25
Copy link
Contributor

Will this be merged?

@TheTyrant25 TheTyrant25 reopened this Jan 10, 2024
@TheTyrant25 TheTyrant25 removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 10, 2024
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 25, 2024
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 30, 2024
@TobleroneSwordfish TobleroneSwordfish merged commit e5f90d7 into goonstation:master Jan 30, 2024
49 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Feature A new feature or enhancements to existing features S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants