New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slug things, slime, dropSweat and wetify procs #17155
Slug things, slime, dropSweat and wetify procs #17155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curse of merge conflict upon ye.
Oh also all instances where you're defining any kind of time should use the SECONDS
define for clarity, that's in variables and proc arguments.
Turns out I hadn't added an if block for superlube in the wetify proc so I added that, but the proc seems a bit bloated now. I can try shave it down if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay uh that doesn't compile because the indentation is all wrong, and invisible lube still needs to wet the turf, you'll need to add a silent
argument to wetify
to cancel the playsound and pass it an alpha
of 0 if visible
is false (also ideally don't set up the overlay at all if the alpha is zero)
Ah I see thanks, I'll get to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final nitpicks
[C-Code-Quality] [A-Chemistry] [A-Catering]
About the PR
Rework of #17026
This PR adds a couple slug related things and includes two procs to cut down on instances of copy pasted code: wetify and dropSweat.
Slime is a new reagent that should generally be considered as a weaker but alternate source of glue for fun recipes and making floors sticky. You get slime by butchering a slug and extracting the goop out of the resulting lesser slugs, or by scooping oozed slime from the floor after eating a slug burger.
Instances where you're setting "wet" to 2 or 3 to cause slippiness is now handled by the proc wetify, which also accepts -1 as slime and -2 as space glue. dropSweat is a similar proc for status effects that cause you to drop liquids.
Some vestigal code may still need to be removed and comments added in a future commit.
Why's this needed?
Funny pun lead to a desire for slug burger. This lead to putting copy pasted code into some procs too.
Changelog