Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ice no longer conductive #17372

Merged
merged 4 commits into from Dec 20, 2023
Merged

Conversation

ThatFiveGuys
Copy link
Contributor

@ThatFiveGuys ThatFiveGuys commented Dec 18, 2023

About the PR

Ice now has conductivity of 2

Why's this needed?

Having a material that you can get in unlimited quantities incredibly easily that's usable for fabs is just bad as it vastly devalues other materials.

Changelog

(u)Ikea
(+)Ice is now an insulator

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2023
@ThatFiveGuys ThatFiveGuys added C-Balance Balance changes, buffs and nerfs A-Materials Deals with our materials system in some way labels Dec 18, 2023
@Valtsu0
Copy link
Contributor

Valtsu0 commented Dec 18, 2023

Hard disagree on the uncrystallinezation
Moliz is already easy to get in large quantities. Ice can't be picked up with scoops, so it requires a little bit of extra effort. Also Ice is crystalline irl, would be weird making it not

@ThatFiveGuys
Copy link
Contributor Author

ThatFiveGuys commented Dec 19, 2023

Hard disagree on the uncrystallinezation Moliz is already easy to get in large quantities. Ice can't be picked up with scoops, so it requires a little bit of extra effort. Also Ice is crystalline irl, would be weird making it not

For some additional context this pr is intended to combat a niche strat to where people put ice dispensers in robotics/mechanics to get CON/CRY-1 to significantly reduce the amount of materials they need for making stuff. This is one of those gameplay over realism things (though Id argue not being able to substitute glass with ice to make something is more realistic), ice being crystalline means that someone can just mechscan a ice dispenser and not worry about going to cargo/buying it from mining. Ice production currently is something you can do incredibly easily on your own to circumvent interacting with other people which is bad.

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it crystalline, remove the conductivity imo. Ice is a crystal but try making wires out of it.

@ThatFiveGuys ThatFiveGuys changed the title Makes ice no longer conductive and crystallline Makes ice no longer conductive Dec 19, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Dec 19, 2023
@Tarmunora Tarmunora merged commit f477911 into goonstation:master Dec 20, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Materials Deals with our materials system in some way C-Balance Balance changes, buffs and nerfs S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants