Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character parts customization #17460

Merged
merged 17 commits into from Dec 28, 2023

Conversation

TobleroneSwordfish
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish commented Dec 27, 2023

About the PR

Adds a framework for allowing "parts" based character customization, ie limbs, eyes, and possibly cyborg parts in future.
Replaces the current custom arms traits with a new option on the appearance tab (maybe should be its own tab in future). This allows you to have, for example, one robot arm and one plant arm.

UI design is my passion
image

Why's this needed?

More character customization and code to help with future customization.

TODO:

  • Handle migrating saved traits
  • Decide whether arms should persist on clone, currently they don't
  • Maybe add an actual icon for missing arms (although using the default missing icon icon does make me giggle)
  • Fix this abomination appearing briefly when you switch to a roach profile:
    image

Changelog

(u)LeahTheTech
(*)The traits "Robotic arms", "Green fingers", and "One armed spaceman" have been removed and replaced with options to customize individual arms. The future is now!

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Dec 27, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2023
Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no crimes against light theme have been committed here.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Dec 28, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit efcc96e into goonstation:master Dec 28, 2023
22 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants