Rework wizard polymorph to timed status effect #17563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flappybatpal
added
C-Balance
github-actions
bot
added
the
size/M
|
Removed the assigned_role changes and check because frankly I couldn't get it to work and it seemed a bit unnecessary now you transform back. The original mob is qdel on the assumption we probably don't want a build up of humans at null if the critters die. |
FlameArrow57
reviewed
Jan 4, 2024
FlameArrow57
reviewed
Jan 4, 2024
TobleroneSwordfish
requested changes
Jan 5, 2024
Co-authored-by: FlameArrow57 <53062374+FlameArrow57@users.noreply.github.com>
Co-authored-by: FlameArrow57 <53062374+FlameArrow57@users.noreply.github.com>
boring-cyborg
bot
added
the
C-Sprites
|
not seeing the new sprite when testing locally |
pgmzeta
approved these changes
Jan 7, 2024
TobleroneSwordfish
requested changes
Jan 12, 2024
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
github-actions
bot
added
the
S-Merge-Conflict
|
Imo four minutes is too short especially when the cooldown is already over two minutes. I think something like seven or eight minutes would be more impactful while not being horrible. |
github-actions
bot
removed
the
S-Merge-Conflict
github-actions
bot
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changes wizard polymorph to use a status effect that will revert you to your human form after eight minutes.
Stores the original mob in null with hibernating set so they can return with the same limbs, organs etc.
Why's this needed?
Being permanently stuck as an animal critter was kind of lame.
Changelog