Declare Ready -> Join Game [when game has already started] #17580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy" button also hide "ready with antag token" option when game starts since you cant redeem it anyway
boring-cyborg
bot
added
the
C-Sprites
github-actions
bot
added
the
size/S
pgmzeta
added
the
A-UI
pgmzeta
approved these changes
Jan 6, 2024
github-actions
bot
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The "Declare Ready" button shows "Join Game" instead if the game has started
Font is Verdana, bold, size 11, modern sharp rendering, done in Paint.NET
Also hides the "Ready with Antag Token" button when game starts, since you cant even redeem it anyway
This only applies if you're in lobby, with an antag token, and the game starts while you are NOT ready
Why's this needed?
Looks cleaner and better, makes more sense, I always thought it was strange that Goon showed "Declare Ready" when game has already started and it opens up the latejoin menu
Changelog