Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds chaplain mechanic 'faith'. Uses it for healing #17597

Merged
merged 11 commits into from Jan 17, 2024

Conversation

Valtsu0
Copy link
Contributor

@Valtsu0 Valtsu0 commented Jan 9, 2024

[game objects][feature][wiki][input]

About the PR

Old thread (not that relevant anymore)
Adds a hidden variable faith to chaplain training
All chaplains will receive all of the produced faith. Faith is used individually.

Faith production

Faith can only be produced by humans, critters, borgs and AI that are a player, conscious and a non-ghost role
chaplains will produce a little bit of faith based on the current faith just by meeting the previous criteria (only to themselves, lower the faith the higher the gain)
everyone else (with a few exceptions) who is in the chapel will produce faith at a much larger speed

Healing

Healing will use 2.5% of your faith to increase the healing done up to a maximum of 30 (at 5000 faith). Will also apply to attacking vampires.
Faith will also increase the chance of successful healing
Starting amount of faith makes the bible the same as currently. Being near 0 faith makes it really bad for healing.

Why's this needed?

It gives a mechanical benefit for chaplains holding sermons and other events.

It also makes it possible for other faith interactions to be added, but they are outside the scope of this pr (maybe chaplain's gun, station grade?)

Changelog

(u)Valtsu0
(*)Chaplain will now gather faith from people in the chapel. Faith will increase the healing done by the bible

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features E-Add-To-Wiki A PR that will require changes to the wiki labels Jan 9, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2024
@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22169

@Valtsu0 Valtsu0 marked this pull request as draft January 9, 2024 20:39
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
@Valtsu0 Valtsu0 changed the title Chaplain's gun 'faith' rework Adds chaplain mechanic 'faith'. Uses it for healing Jan 9, 2024
@Valtsu0 Valtsu0 marked this pull request as ready for review January 9, 2024 23:09
@TDHooligan
Copy link
Contributor

note that this PR was previously some questionable changes for the Faith gun, which is where the negative initial feedback came from

Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than the gun idea

The faith handling feels a little odd to me wrt storing it on the trait, but I suppose it works out

Not sure I'm sold on gaining faith from failed biblehealing, especially what with the interaction with atheist trait. Imo should probably be dropped

Additionally, passive chaplain faith gain could possibly stand to be nonlinear (e.g.: faith += k / faith**0.3), so they can return to a "baseline" level faster

code/obj/item/storage/bible.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be nice to have some occasional vague feedback messages for the chaplain when they heal someone, indicating veeery roughly how strong the heal was. Faith as a mechanic needs to be somewhat opaque, but if it's completely impossible to read then it's going to feel unsatisfying.

@Valtsu0
Copy link
Contributor Author

Valtsu0 commented Jan 12, 2024

Might also be nice to have some occasional vague feedback messages for the chaplain when they heal someone, indicating veeery roughly how strong the heal was. Faith as a mechanic needs to be somewhat opaque, but if it's completely impossible to read then it's going to feel unsatisfying.

I could change the healing message based on the amount, but can't come up with good messages.

@TDHooligan
Copy link
Contributor

TDHooligan commented Jan 12, 2024

I could change the healing message based on the amount, but can't come up with good messages.

i @ ed you in discord (i think) with a backing .ogg you can play over the bible thump. just scale it in volume based on faith maybe

@boring-cyborg boring-cyborg bot added the C-Sound Automatically applied on any .ogg or sound folder change. label Jan 13, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024
@Tarmunora Tarmunora merged commit 65df7e0 into goonstation:master Jan 17, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
@Retrino Retrino removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sound Automatically applied on any .ogg or sound folder change. E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants