Converts oil for borgs into a status effect and rebalances it

[ThatFiveGuys]

About the PR

If you want the tldr of the new oil behavior, in short being oiled recently makes you freshly oiled which makes you go really fast and power efficent for a max of 15 seconds. This decays into the oiled status effect for a max of 6 minutes, which makes you go go somewhat fast and somewhat power efficent. Just look at the video below
https://github.com/goonstation/goonstation/assets/73148980/0258ad07-86d7-4330-8d11-113844f35392

To sum up the old oil behavior for probably unneeded context, one unit of oil applied 2 seconds of being oiled, this status effect reduces your speed by .5, reduces your max stun by 25% + stun resistance by 25, and halves your passive power consumption. This had no clamp.

To sum up the new behavior, this pr splits oil into two status effects, oiled and freshly oiled. Both status effects apply the stun modifiers described above.

Every unit of oil applied to a borg applies half a second of the freshly oiled status effect. This status effect caps out at 15 seconds, meaning you need to apply 30 units to cap this effect. This halves your passive power consumption, and reduces your movement delay by 50%. When freshly oiled is finished, you get applied the oiled status effect with 24 times the duration you've had the freshly oiled status effect for, meaning you have to have freshly oiled for at least 15 seconds to cap out at 6 minutes.

Oiled status effect just reduces your movement delay and passive power consumption by 15%, and also does the same stun modifiers mentioned above.

Why's this needed?

This new behavior is both far more readable, and also far more interesting and fun, also hopefully well balanced.

Changelog

(u)Ikea
(*)The previous behavior for oil in regards to borgs has been split into two status effects, freshly oiled and oiled. These apply speed increase and power consumption decrease in varying amounts, alongside stun resistance.

[github-actions]

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22177

[ZeWaka]

gib bideo u posted in imcoder

[ThatFiveGuys]

gib bideo u posted in imcoder

It was in imspriter you fool, also added

[TDHooligan]

notable it nerfs light borgs' speed bonus more than it nerfs heavy borgs. i like this more than the existing effect

[Tarmunora]

at 15 seconds, the "freshly oiled" thing seems pretty pointless

[ThatFiveGuys]

at 15 seconds, the "freshly oiled" thing seems pretty pointless

Freshly oiled is mostly intended to be a short speed bonus for borgs to apply on themselves sorta similar to how current behavior of oil can be utilized. Also borgs going mach 12 funny.

[ZeWaka]

at 15 seconds, the "freshly oiled" thing seems pretty pointless

Freshly oiled is mostly intended to be a short speed bonus for borgs to apply on themselves sorta similar to how current behavior of oil can be utilized. Also borgs going mach 12 funny.

Yeah, I also thought of/requested/proposed this because it adds a bit of complexity to an otherwise boring "set and forget" feature

[ThatFiveGuys]

Anyways fixed the inconsistency, I have no clue why that part of borg code has so much repeated code anyways, but oh well. Anyways, for some additional context, I did some tests on oshans with light borgs and with the level of speed freshly oiled offers you, you can do half a loop around oshan as a light borg in 15 seconds. Anyways if its a decided no then just tell me and Ill axe freshly oiled, but I think its interesting and neat.