Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower genomes for high-genome plants #17761

Merged
merged 4 commits into from Feb 13, 2024
Merged

Conversation

TDHooligan
Copy link
Contributor

@TDHooligan TDHooligan commented Jan 23, 2024

[HYDROPONICS] [QOL] [BALANCE]

About the PR

Moves genomes for the top 3 plants down:
Slurrypod 45 -> 40
Radweed 40 -> 34
Fungus 30 -> 31

Why's this needed?

The hops from citrus -> fungus and fungus -> radweed are relics from way, way back. Back when botany was RNG hell and you liked it. This makes the botany RNG moderately less miserable without entirely removing the moderately juicy genome hops you need to do for the radweed/slurrypod splice

Changelog

(u)TDHooligan
(+)The RNG gods see botanys' plight. The top 3 genomes have, on average, dropped in value. 

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
@keywordlabeler keywordlabeler bot added A-Hydroponics Deals with plants, hydro, etc. C-Balance Balance changes, buffs and nerfs C-QoL A quality of life improvement that makes the game easier to play labels Jan 23, 2024
@NibChocolateeny
Copy link
Contributor

any reason to making slurreypod 40? maybe 39, so sepration between radweed and slurreypod is still 5, like before

@TDHooligan
Copy link
Contributor Author

figure its probably safer to keep slurrypod a lil higher. its still a fairly safe splice

@M-Earthfire
Copy link
Contributor

Not sure how i feel about making the jump from "normal" plants to slurrypod/radweed possible without splice enabler.

Then again, there are not many plants that would make sense to put into their own genome-category. And if there is one coming up, the genomes can always be increased again.

@TDHooligan
Copy link
Contributor Author

TDHooligan commented Jan 24, 2024

i thought the same thing but also thought that it requiring a dominant species of a plant (so you can get seeds), with splice enabler, purely for 10% chance at some progress towards this, sucked

@Tarmunora
Copy link
Member

Not sure how i feel about making the jump from "normal" plants to slurrypod/radweed possible without splice enabler.

Then again, there are not many plants that would make sense to put into their own genome-category. And if there is one coming up, the genomes can always be increased again.

Agreed - I think there's value in having them be a "wait, is this even possible? Oh shit you can do that!" moment

@TDHooligan
Copy link
Contributor Author

TDHooligan commented Jan 25, 2024

I think there's value in having them be a "wait, is this even possible? Oh shit you can do that!" moment

yeah fair enough. thinking on it ore the crux of the issue is just the fact you need to jump up a huge amount of genome to create something that is likely to be seedless.
hows this?
Fungus -> 31

now you've the splice enabler jump onto something that actually has seeds, if i'm reading the code correctly. removing the requirement for having a recessive Radweed and dominant seeded plant

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 13, 2024
@Tarmunora Tarmunora merged commit 489269b into goonstation:master Feb 13, 2024
25 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
@TDHooligan TDHooligan deleted the patch-4 branch March 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Hydroponics Deals with plants, hydro, etc. C-Balance Balance changes, buffs and nerfs C-QoL A quality of life improvement that makes the game easier to play S-Stale An inactive PR that has had no updates in the past two weeks size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants