Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows feeding viscerite to synthflesh pustules #17768

Merged
merged 8 commits into from
May 13, 2024

Conversation

ThatFiveGuys
Copy link
Contributor

@ThatFiveGuys ThatFiveGuys commented Jan 25, 2024

About the PR

Feeding pustules viscerite now gives the pustule 20 u of viscerite viscera per material. This chem heals 2.5 brute and burn, but deals +1.5 tox, purges chems at the same rate as calomel, and occasionally gives you weakened. The intent here is for it to serve as essientally a reverse pententic acid.

The pustule proceeds to digest the viscera into toxic martian flesh and synthflesh. In the process of digestion, the pustule occasionally emits sulfuric acid, with small/medium pustules doing so in relatively higher quantities with increased frequency. Small/medium pustules produce 7 units of synthflesh and martian flesh, alongside (on average) 4u of sulfuric acid per viscerite, large pustules produce 14 units synthflesh and 2.5 units martian flesh, alongside (on average) 1 units sulfuric acid.

Why's this needed?

Gives some neat usage to viscerite, interdepartmental cooperation and all that alongside making some cool new chems available. Also just seems like a neat and logical interaction,

Changelog

(u)Ikea
(*)Feeding viscerite to synthflesh pustules generates viscerite viscera. The pustule proceeds to digest this chemical into synthflesh and martian flesh, all while offgassing sulfuric acid. Small/medium pustules produce 7 units of synthflesh and 7 units of martian flesh per viscerite, large pustules produce 14 units of synthflesh and 2.5 units of martian flesh per viscerite.
(+) A new chem has been added in the form of viscerite viscera. Currently only obtainable from synthflesh pustules, this chem heals 2.5 brute and burn, all while dealing 1.5 tox, purging other chems, and dealing weakened.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2024
@ThatFiveGuys ThatFiveGuys added E-Add-To-Wiki A PR that will require changes to the wiki A-Chemistry Deals with the chemistry system in some way C-Feature A new feature or enhancements to existing features labels Jan 25, 2024
Co-authored-by: Tarmunora <48066662+Tarmunora@users.noreply.github.com>
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat idea, but I think it should come with some kind of downside to offset how easy it is to get a large quantity of viscerite. Maybe make it add some kind of toxic contaminant or emit weird eldritch smoke. Also probably reduce the efficiency a bit.

code/modules/chemistry/Chemistry-Tools.dm Outdated Show resolved Hide resolved
ThatFiveGuys and others added 2 commits January 29, 2024 19:02
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2024
@ThatFiveGuys
Copy link
Contributor Author

ThatFiveGuys commented Jan 30, 2024

I expanded the behavior by a fair bit, put all the details in the pr description.

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, interesting idea but at that point why not just have the pustule keep the new chem instead of converting into synthflesh?

code/modules/chemistry/Reagents-Misc.dm Outdated Show resolved Hide resolved
code/modules/chemistry/Chemistry-Tools.dm Outdated Show resolved Hide resolved
@ThatFiveGuys
Copy link
Contributor Author

Hmmm, interesting idea but at that point why not just have the pustule keep the new chem instead of converting into synthflesh?

The main purpose of the new chem is mostly because I wanted to have it process over time similar to blood and it using a chem seemed like the easiest way, and at that point might as well give it some unique behavior. Synthflesh is way more versatile so I think that's what most people will want. That being said, It will probably be a good idea to up the brute/burn healing and tox damage a little bit to help cement its niche better, that way it outheals omnizine specifically for brute/burn.

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 16, 2024
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 17, 2024
@ThatFiveGuys
Copy link
Contributor Author

Oh yeah I updated this pr

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 17, 2024
@github-actions github-actions bot closed this Mar 25, 2024
@ThatFiveGuys
Copy link
Contributor Author

Reopenning because staled please review

@ThatFiveGuys ThatFiveGuys reopened this Mar 25, 2024
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 27, 2024
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Apr 10, 2024
@ZeWaka
Copy link
Member

ZeWaka commented Apr 10, 2024

x

@ZeWaka ZeWaka removed the S-Stale An inactive PR that has had no updates in the past two weeks label Apr 10, 2024
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure on the feature but code looks alright enough

code/modules/chemistry/Chemistry-Tools.dm Outdated Show resolved Hide resolved
code/modules/chemistry/Reagents-Misc.dm Outdated Show resolved Hide resolved
ThatFiveGuys and others added 2 commits April 10, 2024 21:03
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
Copy link
Contributor

github-actions bot commented May 4, 2024

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 4, 2024
@ZeWaka
Copy link
Member

ZeWaka commented May 11, 2024

@TobleroneSwordfish

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label May 12, 2024
@TobleroneSwordfish TobleroneSwordfish merged commit 03f6bc4 into goonstation:master May 13, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Chemistry Deals with the chemistry system in some way C-Feature A new feature or enhancements to existing features E-Add-To-Wiki A PR that will require changes to the wiki size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants