Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add external cycling airlocks to cogmap 1 #17828

Merged
merged 3 commits into from Feb 2, 2024

Conversation

TheTyrant25
Copy link
Contributor

@TheTyrant25 TheTyrant25 commented Feb 1, 2024

[MAPPING] [QOL]

About the PR

Adds the new cycling airlock mechanism from #17459 to cogmap1. Spots where they are used are available in mapdiffbot.
To those unfamiliar, all it means is that attempting to open an "outer" door will try to close the "inner door". It only tries it once, however, and is overridden by safety checks. It won't lock you inside, just gently tries to close the other door behind you. These are best applied to setups where two doors separate space and interior.

These were added by using airlock cycle map helpers. I also var edited their names, not just their IDs, so that the strongdmm prefabs tab is more legible.

They have not been added to every single possible place that could use them, notably shuttle docking bays, because they would simply impede foot traffic (and aren't supposed to open out into space anyway). Similarly they're not applied to "departmental airlocks" like in engineering, because it's not... locking air.

This also only adds it to cogmap1 for now. If it's not strongly hated then I'll PR it to other maps.

P.S. This also fixes a pretty critical bug with how cycling airlocks works, ported from coolstation commit d195ae114bca61ec373923b137a323545f929c06

Why's this needed?

It's nice to use them, and should stop air leaking from careless door opening. Seems like something that should have already existed.

Changelog

(u)Tyrant
(+)Some airlocks are now linked in a way that opening one door tries to close the other doors. "Keep the Air Inside!" ~John Nanotrasen probably.

@keywordlabeler keywordlabeler bot added A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play labels Feb 1, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 1, 2024
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 👍

@TheTyrant25
Copy link
Contributor Author

there's also been talk of adding them to interior airlocks but that is out of scope for now. example places would be entrances to research and engineering.

@TheTyrant25 TheTyrant25 changed the title add cycling airlocks to cogmap 1 add external cycling airlocks to cogmap 1 Feb 1, 2024
@TheTyrant25 TheTyrant25 added the C-Feature A new feature or enhancements to existing features label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants