Add end of round gang portraits #17839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobleroneSwordfish
added
C-Feature
github-actions
bot
added
the
size/M
|
Maybe better to show the portraits in the end-of-round summary window, instead of as a HUD overlay |
|
Actually I think TDH wants to do some kind of round-end animation based around this, so I'm just going to merge it as-is and let them cook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds cool portraits of all the members of the winning gang at the end of the round.
Looks something like this:
Only the gang leader's name is gold, dead gang members will show as ghosts.
Why's this needed?
More uhhh Pride and Clout for the winning gang members, hopefully making people more likely to care about winning the round.
This might be a little too in your face, I'm open to suggestions to change it.
Changelog