Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE spawns with the Aurora Belt MkII #17853

Merged
merged 6 commits into from Feb 17, 2024
Merged

Conversation

Cherman0
Copy link
Contributor

@Cherman0 Cherman0 commented Feb 3, 2024

About the PR

Makes the CE spawn with the aurora belt, removes it from their locker.

Why's this needed?

It's somewhat awkward that they dont spawn with their tools. In the force field rework it was changed to reduce melee damage by 75% instead of giving you a 75% chance to dodge all melee attacks, making it significantly less valuable for antags to steal (ie it does nothing against grabs, disarms, batons, etc now). As such I dont feel that it will be an issue that it is not available at all if there's no CE, and it also introduces the benefit that the CE cryoing with their belt doesnt lock it out of existance for any future latejoining CE.

Changelog

(u)Cherman0
(+)The CE now spawns wearing their Aurora Belt MkII

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2024
@Cherman0 Cherman0 changed the title initial commit CE spawns with the Aurora Belt MkII Feb 3, 2024
@Cherman0 Cherman0 added C-QoL A quality of life improvement that makes the game easier to play A-Game-Objects The point of this PR is to deal with a specific game object A-Clothing Deals with clothing of whatever sort labels Feb 3, 2024
@blackrep
Copy link
Contributor

blackrep commented Feb 3, 2024

Doesn't this cause issues with spy thief? The CE's belt can be one of the targets to steal.

@Cherman0
Copy link
Contributor Author

Cherman0 commented Feb 3, 2024

There's already code for removing possible bounties for jobspawn items if there are zero of that job (hos beret and captain auth disk) so i can just add the aurora belt to that

@Tarmunora
Copy link
Member

note this the sequestered cloner prefab will need updating, as a fully-filled CE locker (read: belt) is the main reward

@blackrep
Copy link
Contributor

blackrep commented Feb 6, 2024

note this the sequestered cloner prefab will need updating, as a fully-filled CE locker (read: belt) is the main reward

That prefab has been broken for a while. The CE locker doesn't exist there anymore.

@Cherman0
Copy link
Contributor Author

Cherman0 commented Feb 7, 2024

Yeah, those lockers are empty. Theyre just generic command lockers, not CE lockers.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Feb 7, 2024
code/obj/storage/secure_closets.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Feb 16, 2024
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@Tarmunora Tarmunora merged commit b3dde66 into goonstation:master Feb 17, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Clothing Deals with clothing of whatever sort A-Game-Objects The point of this PR is to deal with a specific game object A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants