TGUIification of TTV menu #17897
Merged
TGUIification of TTV menu #17897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeggalBozale
requested review from
mordent-goonstation,
ZeWaka and
Tarmunora
as code owners
boring-cyborg
bot
added
the
A-UI
github-actions
bot
added
the
size/L
MeggalBozale
added
C-QoL
|
|
|
It looks a little bare, maybe consider doing something like the tank display on the canister UI? (aka steal the component) |
|
Would it be fine to add the pressure indicators for that? I dont feel anything makes that less bare besides providing pressure info |
|
You beat me to it. Looks good 👍 |
|
|
TobleroneSwordfish
requested changes
Feb 8, 2024
TobleroneSwordfish
requested changes
Feb 8, 2024
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
yea Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
|
Committed those, any other minor changes worth making to improve UI/UX lmk i have all of today to work on it |
TobleroneSwordfish
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR serves only to convert the TTV menu to TGUI. There is one mechanical change, which is that you can, only in the menu, select which part of the tank transfer valve to attach a tank to. This has no effect on gameplay, it just felt right to add.
Old menu:
EDIT newer menu:
Old New menu:
Why's this needed?
TGUI is nicer to have and use, and more in-game menus should be converted to using TGUI.
Changelog