German Accent Trait #18050
German Accent Trait #18050
Conversation
boring-cyborg
bot
added
the
C-Sprites
github-actions
bot
added
the
size/L
strings/language/german.txt
Outdated
| oven@=backoven | ||
| over@=uber | ||
| paper@=papier | ||
| peope@=leute |
There was a problem hiding this comment.
| peope@=leute | |
| people@=leute |
strings/language/german.txt
Outdated
| precisely@=genau | ||
| preheat@=vorheiss | ||
| pretty@=schoen | ||
| prezel@=brezel |
There was a problem hiding this comment.
| prezel@=brezel | |
| pretzel@=brezel |
strings/language/german.txt
Outdated
| gadget@=ding | ||
| girl@=maedchen | ||
| god@=gott | ||
| god@=gotte |
There was a problem hiding this comment.
| god@=gotte | |
| gods@=gotter |
god defined twice? cant find much reference to gotte. assume you meant gods/gotter?
There was a problem hiding this comment.
I was typing fast- i did mean gotter haha
strings/language/german.txt
Outdated
| weather@=wetter | ||
| welcome@=wilkommen | ||
| what@=was | ||
| what@=was |
There was a problem hiding this comment.
| what@=was |
"what" defined twice.
|
Ack- typos. I'll fix em now. thanks for finding them |
|
Not sure if this is an issue with this accent or accents in general but the two letter replacements play weirdly with capital letters, so |
code/procs/accents.dm
Outdated
|
|
||
| var/list/phrases = list("excuse me=entschuldigung","yes sir=javol","yes ma'am=javol","you stink=du stinkst","good morning=guten morgen" | ||
| ,"good day=guten tag", "good evening=guten abend", "good night=guten nacht","thank you=danke","thank you very much=danke schoen","I'm sorry=es tut mir leid","that's too bad=schade","no problem=kein problem" | ||
| ,"good luck=viel glueck","bless you=gezundheit","good afternoon=guten tag")//this is horrible. I'll come up with a better system later, but I have work to do right now. This is for multi-word phrases the document can't pick up. I'm going to convert this list to a text document when I have time. |
There was a problem hiding this comment.
This could also just be an associative list?
There was a problem hiding this comment.
okay, I fixed the stinky code I had there before. Nice and clean now!
I'm pretty sure that is a flaw with the general accent system, but I'll look into finding a fix for that |
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
|
Not stale, I'm still working on it! |
github-actions
bot
removed
the
S-Stale
| @@ -150,6 +150,29 @@ | |||
| message = finnishify(message) | |||
| return message | |||
|
|
|||
| /datum/bioEffect/speech/german | |||
| name = "Frontal Gyrus Alteration Type-DE" | |||
| desc = "Forces the language center of the subject's brain to construct scentences in a German manner." | |||
There was a problem hiding this comment.
typo typo typo typo typo typo
There was a problem hiding this comment.
ach- sorry. Dysgraphia moment. I always spell that wrong. Fixing now
|
Oops- didnt mean to push that yet |
|
Sorry I've never done a proper review, I didn't know how to suggest changes fancy like the others. |
In the Files changed navitem at the top you can click the plus symbol on a line of code to add a comment |
That's kind of what I did, I just added a lot of comments. My review just looked really busy I wasn't sure if I did it right. |
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
I'm not sure if it worked, as I can't see any of your comments/suggestions on the code. |
code/procs/accents.dm
Outdated
| var/list/phrase = list( | ||
| "excuse me" = "entschuldigung", | ||
| "yes sir" = "javol", | ||
| "yes maam" = "javol", | ||
| "yes ma'am" = "javol", | ||
| "good morning" = "guten morgen", | ||
| "good day" = "guten tag", | ||
| "good afternoon" = "guten tag", | ||
| "good evening" = "guten abend", | ||
| "good night" = "guten nacht", | ||
| "thank you" = "danke", | ||
| "that's too bad" = "schade", | ||
| "thats too bad" = "schade", | ||
| "too bad" = "schade", | ||
| "no problem" = "kein problem" | ||
| ) |
There was a problem hiding this comment.
why have this in addition to german.txt?
There was a problem hiding this comment.
so, the accent system doesn't support multi word phrases in a text document. I could put those into another doc, but I was told to just make an associative list
There was a problem hiding this comment.
I could also rework the system itself, but I want to keep the phrases and the single word replacements seperate
There was a problem hiding this comment.
worth adding that as a comment at least - reduce potential future confusion
There was a problem hiding this comment.
alrighty. I'll try and comment the code a bit better
github-actions
bot
removed
the
S-Stale
There was a problem hiding this comment.
In the Files changed navitem at the top you can click the plus symbol on a line of code to add a comment
That's kind of what I did, I just added a lot of comments. My review just looked really busy I wasn't sure if I did it right.
I'm not sure if it worked, as I can't see any of your comments/suggestions on the code.
You're right. I didn't click "Request changes".
code/procs/accents.dm
Outdated
|
|
||
| var/list/phrase = list( | ||
| "excuse me" = "entschuldigung", | ||
| "yes sir" = "javol", |
There was a problem hiding this comment.
The word is spelled "Jawohl."
strings/language/german.txt
Outdated
| oh@=aeh | ||
| old@=alt | ||
| one@=eins | ||
| orange@=orangen |
strings/language/german.txt
Outdated
| old@=alt | ||
| one@=eins | ||
| orange@=orangen | ||
| oven@=backoven |
strings/language/german.txt
Outdated
| shame@=scham | ||
| shameful@=schamvoll | ||
| she@=sie | ||
| shit@=sheisse |
strings/language/german.txt
Outdated
| shameful@=schamvoll | ||
| she@=sie | ||
| shit@=sheisse | ||
| shitcurity@=scheipolizei |
There was a problem hiding this comment.
Should be "Scheisspolizei"
There was a problem hiding this comment.
I'm just going to remove the shitsec ones alltogether
strings/language/german.txt
Outdated
| soup@=suppe | ||
| sour@=sauer | ||
| stone@=stein | ||
| stones@=steinen |
strings/language/german.txt
Outdated
| wonderful@=wunderbar | ||
| worm@=wurm | ||
| yes@=ja | ||
| yessir@=javol |
| true@=rightig | ||
| false@=falsch | ||
| head@=kopf | ||
| care@=kare |
There was a problem hiding this comment.
This I don't understand at all.
There was a problem hiding this comment.
Oop- typo. that's meant to be richtig
strings/language/german.txt
Outdated
| false@=falsch | ||
| head@=kopf | ||
| care@=kare | ||
| sweet@=suss |
| head@=kopf | ||
| care@=kare | ||
| sweet@=suss | ||
| grass@=glas |
|
fixing all the typos now- thanks for catching them. I've really gotta be more careful |
github-actions
bot
added
the
S-Merge-Conflict
|
!merge_upstream |
|
Merging upstream failed: |
|
scheisse |
TobleroneSwordfish
merged commit dec96bf
into
goonstation:master
[A-TRAITS]
About the PR
(git broke- I'm adding the labels now- not sure why they didn't go up with the pr)
This pr seeks to add a german accent to the game, which will appear as a cute little pretzel icon in the language traits section. I am a german speaker, so I tried to make this as accurate as possible. However, German is only my second language so I had a native speaker over on discord help me a bit. A pretty big hurdle with this is the MANY different dialects of German, and how they all sound very different from each other. They are so extreme that alot of the times southern German shows will be subbed for Northern audiences so they can understand them. I chose to go with Hochdeutsch, as that is the standard form of German understood by most German speakers.
This functions similarly to how the scots dialect works, with a few differences. Similarly to the scots code, there is a list of words that replace certain words in the sentence. These are cognates that are similar to english and mostly understandable by purely english speakers, with a other few common(and perhaps a little stereotypical) words thrown in there. The key difference is that the modified tokens are run into the parser, so they are spelled incorrectly but are pronounced correctly if read like English.
demo:
https://youtu.be/3RakGHF6lOM
Why's this needed?
I think there should be more accents in the game, and I recieved positive feedback from multiple people when I demo'd my little test of this when I was bored. I was pretty dissapointed when I first started playing a few years ago and saw no German accent.
Changelog