Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyebots now come with a portable intercom #18085

Merged
merged 2 commits into from Apr 16, 2024

Conversation

ThatFiveGuys
Copy link
Contributor

About the PR

Eyebots now come with a tiny handheld intercom that has broadcasting and listening to false by default

Why's this needed?

Gives eyebots more utility in the spying on people department which sounds like fun

Changelog

(u)Ikea
(*)Eyebots now come with a portable intercom.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Mar 2, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2024
@ThatFiveGuys ThatFiveGuys added C-Feature A new feature or enhancements to existing features E-Add-To-Wiki A PR that will require changes to the wiki A-AI Deals with some sort of mob or critter AI in the game A-Silicons Deals with the angry metal robots and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2024
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 17, 2024
@github-actions github-actions bot closed this Mar 25, 2024
@ThatFiveGuys
Copy link
Contributor Author

Reopenning because staledn

@ThatFiveGuys ThatFiveGuys reopened this Mar 25, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2024
@Kyle2143
Copy link
Contributor

IMO add a sprite change when it's listening. Like a red "recording" light somewhere visible on it. So at least people know when they're being spied on.

@ThatFiveGuys
Copy link
Contributor Author

ThatFiveGuys commented Mar 26, 2024

IMO add a sprite change when it's listening. Like a red "recording" light somewhere visible on it. So at least people know when they're being spied on.

I dont think this change would help gameplay. Intercoms dont do this, so being spied on without immediate indication isnt a new thing. Eyebots stick out as is and Id like the ai to have some plausible deniability when it comes to spying “oh they just so happened to leave their shell in sec” and people to treat that accordingly “oh let me move this eyebot just in case” (or not do that!). A sprite indication would ruin that nuance of that interaction and reduce it to “oh the ai is spying on me” instead of “the ai is maybe spying on me”

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 27, 2024
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Apr 10, 2024
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Apr 12, 2024
@Tarmunora Tarmunora merged commit 65f888a into goonstation:master Apr 16, 2024
23 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-AI Deals with some sort of mob or critter AI in the game A-Silicons Deals with the angry metal robots C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants