Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Icons to wizard spellbook UI #18136

Conversation

IPling
Copy link
Contributor

@IPling IPling commented Mar 7, 2024

About the PR

Adds icons for each spell (Except Soulguard since it doesnt have a spell icon) to the wizard spellbook UI I made, since when making it I had no clue how to actually add them.

Preview image: (Made the window a bit bigger to show more spells for the preview.)
image

Why's this needed?

Visually looks much more pleasant and was previously suggested.

Changelog

(u)IPingu
(+)Adds Icons to spells in the wizard spellbook

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Mar 7, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Mar 7, 2024
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 23, 2024
@ZeWaka
Copy link
Member

ZeWaka commented Mar 24, 2024

X

@ZeWaka ZeWaka removed the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 24, 2024
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Mar 24, 2024
@Tarmunora
Copy link
Member

image
when spell is ineligible in VR, top couple pixels of the icon for the next spell down is greyed out too

@IPling
Copy link
Contributor Author

IPling commented Mar 24, 2024

when spell is ineligible in VR, top couple pixels of the icon for the next spell down is greyed out too

Ah yeah, must have forgotten to test in VR.
Probably from the constant margins I had to do to get it just right, since sections really dont like it when I add images to em.
Will see what I can do tomorrow to fix that.

@IPling
Copy link
Contributor Author

IPling commented Mar 26, 2024

Looks good now.
image

tgui/packages/tgui/interfaces/Wizard_Spellbook.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Wizard_Spellbook.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Wizard_Spellbook.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Wizard_Spellbook.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/Wizard_Spellbook.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Apr 2, 2024
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
@IPling
Copy link
Contributor Author

IPling commented Apr 3, 2024

Updated the preview image to match the 32x32

@mordent-goonstation
Copy link
Contributor

Needs a changelog. I want to pull this one down locally and poke at it a bit.

@IPling
Copy link
Contributor Author

IPling commented Apr 4, 2024

Changelog made.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2024
@mordent-goonstation mordent-goonstation merged commit 195fe80 into goonstation:master Apr 6, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants