Makes cryoing free up slots for non-unique jobs #18145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Respawning
github-actions
bot
added
the
size/XS
goonstation-issuebot
added
the
S-Testmerged
This was referenced Mar 8, 2024
|
After playing and observing a few rounds with this I feel that while this is a great change, more jobs should be counted as unique since ending up with two chaplains and two detectives was feeling kinda meh for them from what I gathered. Imo all command jobs, detective, chaplain, and probably most 1 slot gimmick roles like radio host and inspector should be counted as unique. |
This was referenced Mar 11, 2024
Closed
This was referenced Mar 12, 2024
goonstation-issuebot
removed
the
S-Testmerged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BALANCE] [RESPAWNING]
About the PR
Marks some jobs (heads of staff) as unique, cryoing as a non-unique job will now immediately free up the slot instead of requiring ghosting. Cryo-ghosting will still free up a unique job slot.
Why's this needed?
Feedback from the #18096 testmerge, people were having issues with secoffs cryoing and still taking up slots. Yes this allows for circumventing slot restrictions by cryoing, but this was already possible under the old system by dying and being cloned so 馃し
Changelog