Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camera status and coverage on de/reconstruction #18192

Merged
merged 1 commit into from Mar 22, 2024

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Mar 12, 2024

[bug][balance][game objects][station systems]

About the PR

  • Implement the to/from frame procs on cameras to update status and refresh camera coverage.
  • Update the emp_act proc to ensure it updates camera active/coverage consistently while we're here.

This implementation results in some game balance changes, notably:

  • Removed cameras show as (deactivated), so antagonists removing a camera have a higher chance to be discovered.
  • Viewers cannot tell whether a deactivated camera is broken or deconstructed, requiring investigation to confirm.

Why's this needed?

Fixes #18186

Test Plan

  • Viewers are disconnected when the camera is deconstructed
  • AI sees static when camera is deconstructed
  • Camera is usable after being constructed
  • AI gains sight when camera is constructed

Changelog

(u)glowbold
(*)Deconstructed cameras now show as "Deactivated" instead of disappearing from the camera list.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature labels Mar 12, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2024
@UrsulaMejor UrsulaMejor merged commit d276294 into goonstation:master Mar 22, 2024
31 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
@pgmzeta pgmzeta deleted the pgmzeta/issue18186 branch March 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing Deconstructed Cameras Through Security Cameras Works
2 participants