Adding some sound effects and animations for rockbox damage #18208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Game-Objects
github-actions
bot
added
the
size/M
|
Video showing new behaviour RockboxDamage.mov |
ZeWaka
reviewed
Apr 10, 2024
…disabled and improved feedback if the rock box is broken.
github-actions
bot
added
size/L
github-actions
bot
added
size/M
Tarmunora
approved these changes
Apr 10, 2024
ZeWaka
approved these changes
Apr 11, 2024
github-actions
bot
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OBJECTS][ENHANCEMENT]
About the PR
The rockbox can be destroyed, but when a player attacked the rockbox it behaved like an object that could not be destroyed, at least not without an explosion. This also makes the rockbox inoperable if it has been destroyed, unlike before where it was still usable except the remote purchasing of ore didn't work.
Why's this needed?
I think if a machine can be destroyed it should show some indication that damage is being done.