Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dropping 2 handed items from your inventory with only 1 free hand. #18210

Merged
merged 11 commits into from Mar 16, 2024

Conversation

Valtsu0
Copy link
Contributor

@Valtsu0 Valtsu0 commented Mar 14, 2024

[objects][qol]

About the PR

Currently clicking on a 2 handed item while having only one hand drops it on the ground. This pr prevents that if the item is "in" you. So you can still take 2 handed items out of backpacks on the ground and pickpocket them from people you are pinning, but not take the Hadar heavy power-sword from your back while holding a sawfly remote.

If you have a 2 handed item on your back and you have lost one of your hands you are going to need some help.

Why's this needed?

Thread
Removes a bunch of accidentally dropping stuff, mostly weapons during combat, because you forgot you were holding an item.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play labels Mar 14, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2024
@DisturbHerb
Copy link
Contributor

Personally unsure about this, I've done this deliberately a few times.

@Valtsu0 Valtsu0 changed the title Prevent dropping 2 handed items out of your inventory with only 1 free hand. Prevent dropping 2 handed items from your inventory with only 1 free hand. Mar 14, 2024
code/mob/living/carbon/human.dm Outdated Show resolved Hide resolved
code/atom.dm Outdated Show resolved Hide resolved
Valtsu0 and others added 2 commits March 15, 2024 02:03
Co-authored-by: Ryan <ryan@crystal.surf>
Co-authored-by: Ryan <ryan@crystal.surf>
@pgmzeta
Copy link
Contributor

pgmzeta commented Mar 15, 2024

ah, my bad on the build error; i think the suggestions had spaces instead of tabs

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like this, it's almost never intentional and often very annoying.

@Sord213
Copy link
Contributor

Sord213 commented Mar 16, 2024

good change. I'd love to see it so you can wield 2handed items 1handed with a severe downside, but that's a whooooole other thing.

@TobleroneSwordfish TobleroneSwordfish merged commit 9e0c856 into goonstation:master Mar 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants