Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use medical record disability fields instead of listing all traits #18226

Merged
merged 9 commits into from Mar 29, 2024

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Mar 16, 2024

[QOL][STATION-SYTEMS][MEDICAL]

About the PR

Instead of listing all character traits in medical records, add major and minor disabilities based on the following traits:

  • Major: Deaf, Blind, Stumped, Puritan
  • Minor: Short-sighted, Hemophilia, Frail Constitution, Hyperallergic

These specific traits were included because they are medically relevant and likely to be recorded in medical records. Disability names use medical-themed verbiage instead of the trait name verbatim.

Why's this needed?

Make it clearer to doctors what the impact of traits to their job duties in an unobtrusive and in-universe way.

"Don't clone a puritan!!!" How would you know that unless you already knew what the Puritan trait was/meant?

Screenshot

An in-game screenshot showing a medical record with a large number of disabilities via both PDA and MedTrak.
image

Changelog

(u)glowbold
(*)Medical records now list relevant traits as major/minor disabilities instead of a full list.

@keywordlabeler keywordlabeler bot added A-Medical Deals with our medical system in some way C-QoL A quality of life improvement that makes the game easier to play labels Mar 16, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2024
@pgmzeta pgmzeta added the A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell label Mar 16, 2024
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea, makes sense. Could maybe remove the traits list entirely now that the medically relevant ones are listed here?

code/datums/datacore.dm Outdated Show resolved Hide resolved
@pgmzeta pgmzeta changed the title Add some traits to medical record disability lists Use medical record disability fields instead of listing all traits Mar 28, 2024
code/datums/datacore.dm Outdated Show resolved Hide resolved
code/datums/datacore.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Mar 29, 2024
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@Tarmunora Tarmunora merged commit c15c45c into goonstation:master Mar 29, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
@pgmzeta pgmzeta deleted the feature-medical-datacore branch April 2, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Medical Deals with our medical system in some way A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-QoL A quality of life improvement that makes the game easier to play S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants