New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use medical record disability fields instead of listing all traits #18226
Merged
Tarmunora
merged 9 commits into
goonstation:master
from
pgmzeta:feature-medical-datacore
Mar 29, 2024
Merged
Use medical record disability fields instead of listing all traits #18226
Tarmunora
merged 9 commits into
goonstation:master
from
pgmzeta:feature-medical-datacore
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Medical
Deals with our medical system in some way
C-QoL
A quality of life improvement that makes the game easier to play
labels
Mar 16, 2024
github-actions
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Mar 16, 2024
pgmzeta
added
the
A-Station-Systems
Deals with station systems, e.g. networks, power, shields, belt hell
label
Mar 16, 2024
TobleroneSwordfish
requested changes
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea, makes sense. Could maybe remove the traits list entirely now that the medically relevant ones are listed here?
TobleroneSwordfish
approved these changes
Mar 17, 2024
pgmzeta
changed the title
Add some traits to medical record disability lists
Use medical record disability fields instead of listing all traits
Mar 28, 2024
ZeWaka
approved these changes
Mar 29, 2024
github-actions
bot
added
the
S-Ready-For-Final-Review
This PR has been looked over by members of the community. (automatic after 2 approvals)
label
Mar 29, 2024
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Medical
Deals with our medical system in some way
A-Station-Systems
Deals with station systems, e.g. networks, power, shields, belt hell
C-QoL
A quality of life improvement that makes the game easier to play
S-Ready-For-Final-Review
This PR has been looked over by members of the community. (automatic after 2 approvals)
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[QOL][STATION-SYTEMS][MEDICAL]
About the PR
Instead of listing all character traits in medical records, add major and minor disabilities based on the following traits:
These specific traits were included because they are medically relevant and likely to be recorded in medical records. Disability names use medical-themed verbiage instead of the trait name verbatim.
Why's this needed?
Make it clearer to doctors what the impact of traits to their job duties in an unobtrusive and in-universe way.
"Don't clone a puritan!!!" How would you know that unless you already knew what the Puritan trait was/meant?
Screenshot
An in-game screenshot showing a medical record with a large number of disabilities via both PDA and MedTrak.
Changelog