Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarion Armory/HoS Rework #18299

Closed
wants to merge 35 commits into from
Closed

Conversation

JORJ949
Copy link
Contributor

@JORJ949 JORJ949 commented Mar 24, 2024

[Mapping] [Rework] [Feedback]

About the PR

-Swaps around Armory and HoS office on clarion.
-Replaces empty corridor next to AI core with radio room and moves associated objects from bridge to there
-Changes Antibio crate outside of Armory to sec equipment access.
image

Why's this needed?

Armory foyer is incredibly cramped and situations in which Armory is needed multiple people will need in.
Empty corridor was weird.
HoS Office was also quite cramped but also fits better being between sec and bridge.
HoS now gets the proper mug.

Changelog

(u)JORJ949
(*)Reworked Clarion Armory/HoS office
(*)Moved clarion headset crate to new "Radio Room"

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Mar 24, 2024
@keywordlabeler keywordlabeler bot added A-Mapping A mapping change C-Rework Reworks a feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Mar 24, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 24, 2024
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22447

@JORJ949
Copy link
Contributor Author

JORJ949 commented Mar 24, 2024

Yes ive seen the random data terminal

@JORJ949
Copy link
Contributor Author

JORJ949 commented Mar 24, 2024

Not sure whats different up and around the ring

@pgmzeta
Copy link
Contributor

pgmzeta commented Mar 24, 2024

here's an in-game screenshot, might want to add to the thread/PR desc
image

is this area still supposed to be sticking out of the ai core area (per #18288)
image

armory wiring needs some tuning
image
west side wiring there isn't needed afaict
east/north side window-grilles should have power nodes under them to shock people

Copy link
Contributor

@pgmzeta pgmzeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of wiring tweaks needed around the armory, see other comment

@JORJ949
Copy link
Contributor Author

JORJ949 commented Mar 25, 2024

Loafer and wires have been fixed

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Apr 9, 2024
@boring-cyborg boring-cyborg bot added the A-Tooling Changes tooling for the repository. label Apr 15, 2024
@JORJ949
Copy link
Contributor Author

JORJ949 commented Apr 15, 2024

It would appear I misclicked rebase instead of merge D:

@JORJ949 JORJ949 closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change A-Tooling Changes tooling for the repository. C-Rework Reworks a feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants