Small refactor of food_and_drink/plants.dm
and addition of chems to baseline-produce
#18318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[hydroponics][catering][code quality][balance]
About the PR
This PR does two things:
firstly, a small cleanup of
food_and_drink/plants.dm
. Mostly making mutated produce be inherited from thier respectable baseline produce, like blackberries being a child of raspberries. Also, moving the pumpkin hats to/clothing/plants.dm
. Above that, on occasions where food was manipulated (synthoranges, popcorn popping or spooning pumpkins) it was made sure that the chems of the baseline item were transferred properly.Secondly, this overhauls
make_reagents
and its use withinfood_and_drink/plants.dm
. The variablemade_reagents
was removed. Secondly, this PR adds the respectable botany chems to their corresponding baseline-produce via the use ofmake_reagents
. As a baseline 10u was chosen, although many old exceptions were kept where appropriate, although most were adjusted to slightly lower values than they were before.Why's this needed?
There were multiple people talking about botany produce having no chems at all and some produce in general being spawned dry through cargo or chef vendor. For the botany side of things, a PR was made that i personally didn't thought would solve the issue without other problems (#17886). This PR is the alternative i suggested in the discussion of that particular PR. In general, this will make it so botanists actually need to have really bad-quality produce to make them remove all chems (and add yuck to rub it in for good measure).
This method also affects chef or cargo-produce. This fixes #16487.
Make_reagents
was used instead ofinitial_reagents
because it can be made to respect inheritence (e.g. pumpkin spice gaining the pumpkin juice from baseline-pumpkins).Made_reagents
was removed since it wasn't used and actually didn't do anything when set to true outside of new() or the object's definition.Changelog