Modify the search function in Secmate to allow searching by criminal status. #18326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XS
keywordlabeler
bot
added
the
C-QoL
pgmzeta
reviewed
Mar 27, 2024
| @@ -587,6 +587,9 @@ | |||
| var/list/datum/db_record/results = list() | |||
| for(var/datum/db_record/R as anything in data_core.general.records) | |||
| var/haystack = jointext(list(ckey(R["name"]), ckey(R["dna"]), ckey(R["id"]), ckey(R["fingerprint"]), ckey(R["rank"])), " ") | |||
| var/haystack_secure_addition = data_core.security.find_record("name", R["name"]) | |||
There was a problem hiding this comment.
Not sure! ID probably would've been better! It's more or less my first dive into it at all, so a bit of a learning experience. I'll change it to use ID instead, shortly.
TobleroneSwordfish
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Game-Objects] [QoL]
About the PR
Changes the way the secmate search function works under the hood to allow it to check security records for criminal statuses that match the searched string.
Why's this needed?
Two reasons. First, quality of life in allowing quicker cataloguing of all that are set to a certain status such as arrest, or parole. Secondly, hopefully encouraging further use of secmate record updating so that this may be used as a way to quickly peek through all of a current status to see why they may be set to said status as either a way to jog your own memory during a rather hectic round, or if you happen to be a late comer to one.
Changelog