Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Contact CDC" option from QM Console #18336

Merged
merged 1 commit into from Mar 29, 2024
Merged

Remove "Contact CDC" option from QM Console #18336

merged 1 commit into from Mar 29, 2024

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Mar 28, 2024 •
edited

About the PR

Removes the "Contact CDC" link from the QM console, as well as its related functionality and supporting objects.

Why's this needed?

Pathology was removed

Screenshot

image

Changelog 

(u)glowbold
(+)NanoTrasen no longer has a direct line of contact with the CDC.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2024
@pgmzeta pgmzeta added C-Removal Removal of an existing feature A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell labels Mar 28, 2024
ZeWaka
ZeWaka approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah patho aint coming back, not with any of this code anyways

@ZeWaka ZeWaka merged commit 7574371 into goonstation:master Mar 29, 2024
27 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
@robuddybot
Changelog for #18336 [skip ci]
fd1f8b1
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Mar 29, 2024
@pgmzeta pgmzeta deleted the qm-remove-cdc branch April 2, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeWaka ZeWaka ZeWaka approved these changes

@Tarmunora Tarmunora Tarmunora approved these changes

Assignees
No one assigned
Labels
A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Removal Removal of an existing feature S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgmzeta @ZeWaka @Tarmunora