Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Event: "Illegal" trinkets count as contraband #18372

Merged
merged 3 commits into from Apr 5, 2024

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Apr 1, 2024

About the PR

Random event to mark all player trinkets named with a specific set of "illegal" words as level 3 contraband.

Why's this needed?

Give security some low-stakes cases to tackle.

Changelog

(u)glowbold
(+)NanoTrasen randomly screens trinkets for contraband.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2024
@pgmzeta pgmzeta added C-Feature A new feature or enhancements to existing features A-Events Deals with game events, like meteor showers and such labels Apr 1, 2024
@TDHooligan
Copy link
Contributor

TDHooligan commented Apr 1, 2024

fun idea, will sec actually follow up on these though?
might need some incentives outside of just knowing it exists

@cheekybrdy
Copy link
Contributor

Other then a small typo on the centcom message looks good!

@ZeWaka ZeWaka merged commit ee95ce3 into goonstation:master Apr 5, 2024
23 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@pgmzeta pgmzeta deleted the illegal-trinkets branch April 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Events Deals with game events, like meteor showers and such C-Feature A new feature or enhancements to existing features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants