Adds Job XP reward for completing crew objectives #18430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Player-Actions
github-actions
bot
added
the
size/XS
|
Job XP is meh in general, but assuming we want to keep it around this decision seems fine |
|
Even if we're not keeping it around, it's here now, so some improvements to it would benefit the game regardless |
|
What the game truly needs are missions that are actually fun doing. There's only so many times where protecting Stirstir or having blood in your alcohol stream is actually enjoyable. We'd need more varied, dynamic objectives, maybe stuff that targets specific players or specific substances, that would get people to do them rather than ignore them. But this is a good change either way. |
ZeWaka
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
When a crew objective is completed, it grants XP (Default 50) for whatever job the mind was assigned at the start of the round. This includes jobs that otherwise wouldn't be able to gain XP, like Captain.
Why's this needed?
It makes a good deal of sense for job XP to be awarded when you complete job-specific quests, and it helps out jobs that otherwise have little to no XP gain (like Bartender, whose top 20 players have a median of less that 1,500 XP). It still shouldn't be a major source of XP if you're grinding out hundreds of XP per shift, but it'll help a lot if the way you play your role doesn't involve repeatedly doing the things that give XP. This extra incentive to do objectives might also promote people adding new, interesting objectives, or just interacting with them more in general!