TGUI Search component and disposal / mail chute UI #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
A-UI
keywordlabeler
bot
added
the
C-Feature
Sovexe
added
the
E-DNM
github-actions
bot
added
the
S-Merge-Conflict
…nto disposal-tgui
Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com>
…into disposal-tgui
github-actions
bot
added
S-Merge-Conflict
Sovexe
removed
the
E-DNM
|
probly want the text box thing fixed b4 merge |
mordent-goonstation
approved these changes
Aug 21, 2020
…nto disposal-tgui
ZeWaka
added
the
E-DNM
|
blocking this due to the input thing |
github-actions
bot
added
S-Merge-Conflict
…nto disposal-tgui
github-actions
bot
removed
the
S-Merge-Conflict
|
I've redone the design on this to have a look and feel closer to that of the other UIs that I have designed Because the code was changed so significantly in the process I am re-requesting a review from Mordent |
github-actions
bot
added
the
S-Merge-Conflict
mordent-goonstation
approved these changes
Sep 2, 2020
…nto disposal-tgui
github-actions
bot
removed
the
S-Merge-Conflict
Sovexe
removed
the
E-DNM
…nto disposal-tgui
…nto disposal-tgui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
edit: I've redesigned my initial submission significantly to a newer cleaner feel
Images below are of previous revision
NOTE: the Disposal Handle label in the images has been renamed Chute Handle, very small change so i didnt make new pics
https://user-images.githubusercontent.com/33204415/90360958-062c3f00-e02b-11ea-9901-c078c8f66c4c.png
https://user-images.githubusercontent.com/33204415/90360991-16441e80-e02b-11ea-848c-13fbcac33d9f.png
https://user-images.githubusercontent.com/33204415/90361022-2825c180-e02b-11ea-8ef4-87a005e21dc6.png
https://user-images.githubusercontent.com/33204415/90361079-4f7c8e80-e02b-11ea-87ee-be95da7f59ce.png
https://user-images.githubusercontent.com/33204415/90361144-75099800-e02b-11ea-991e-48f8702b55b8.png
There is a known issue with text input fields that should be fixed before this is merged. While it is functional as is, the user experience would be poor when searching for mail destinations.
Why's this needed?
Changelog