Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossing off items in artifact analysis form #18454

Merged
merged 6 commits into from Apr 10, 2024

Conversation

Valtsu0
Copy link
Contributor

@Valtsu0 Valtsu0 commented Apr 9, 2024

[ui][qol]

About the PR

Cross off by clicking on a selected item, meaning double clicking on a non selected item will cross it out. Click it again to uncross it.
image
Also, no longer passes the pen check result trough the client for no reason (?).

Why's this needed?

It makes sense

Changelog

(u)Valtsu0
(+)You can now cross off items in the artifact analysis form by double clicking.

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Apr 9, 2024
@keywordlabeler keywordlabeler bot added A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-QoL A quality of life improvement that makes the game easier to play labels Apr 9, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@Azrun
Copy link
Contributor

Azrun commented Apr 10, 2024

The future is amazing! Erasable pens!

@ZeWaka ZeWaka added the A-Science Deals with Artifacts, Telescience, or the department label Apr 10, 2024
code/obj/artifacts/artifactanalysis.dm Outdated Show resolved Hide resolved
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@Tarmunora Tarmunora merged commit 3355f92 into goonstation:master Apr 10, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Science Deals with Artifacts, Telescience, or the department A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-QoL A quality of life improvement that makes the game easier to play size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants