Early gang leader dropouts transfer their role #18475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
pgmzeta
added
A-Gamemodes
goonstation-issuebot
added
the
S-Testmerged
This was referenced Apr 20, 2024
Open
goonstation-issuebot
removed
the
S-Testmerged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
If gang leaders die less than 20 minutes into a shift, leadership will pass over instantly (if the leader has not placed a locker) or in 5 minutes if the gang leader has placed a locker.
Why's this needed?
Leaders don't always cryo - some suicide when they aren't up to the task of playing Gang Leader.
Gangs still lasts a full shift, even if the leader offs themself. And headless gangs suck.
However, gangs should also still be stoppable later on if they're causing trouble. 20 minutes seems like a reasonable buffer.
Changelog