Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See SecHUD Flag regardless of arrest icon status #18486

Merged
merged 1 commit into from Apr 13, 2024

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Apr 13, 2024

[feature][station-systems][possibly-intended]

About the PR

No longer check for arrest status (via icon_state) for adding SecHUD Flag text to a person's description.

Will result in more data_core usage.

Why's this needed?

Fix #18479

Changelog

(u)glowbold
(+)SecHUD users can see a person's SecHUD Flag regardless of criminal status.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Apr 13, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2024
@pgmzeta pgmzeta added A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell S-Possibly-Intended A bug covered by a bug report or fix PR may be intended, and needs dev feedback labels Apr 13, 2024
@Tarmunora Tarmunora merged commit bca1df5 into goonstation:master Apr 13, 2024
25 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 13, 2024
@pgmzeta pgmzeta deleted the sechud-no-arrest branch April 14, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Feature A new feature or enhancements to existing features S-Possibly-Intended A bug covered by a bug report or fix PR may be intended, and needs dev feedback size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecHUD flags not showing on examine with sechud
2 participants